-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enabled
property for ST storage objects, fix bug related to saving ST objects
#1807
Conversation
Watermelon AI SummaryAI Summary deactivated by flomnes GitHub PRs
Antares_Simulator is an open repo and Watermelon will serve it for free. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of
for (...)
if (!cluster.enabled()) continue;
we could expose an iterator to iterate over enabled clusters only. WDYT ?
Check indexes for |
9f0a3a3
to
d6446cb
Compare
d6446cb
to
c2f20e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a unit test on the save function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename short-term-storage-input-output.cpp
enabled
property for ST storage objectsenabled
property for ST storage objects, fix bug related to saving ST objects
Quality Gate failedFailed conditions 4.5% Duplication on New Code (required ≤ 3%) |
enabled
for each ST storage objectenabled
, remove it from computations relatively early (right after loading the data), using a similar mechanism as thermal & renewable clusters