Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unuseful yuni string separator #1788

Closed
wants to merge 3 commits into from
Closed

remove unuseful yuni string separator #1788

wants to merge 3 commits into from

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Nov 23, 2023

No description provided.

@a-zakir a-zakir closed this Nov 24, 2023
@a-zakir a-zakir reopened this Nov 28, 2023
@a-zakir a-zakir closed this Nov 28, 2023
@a-zakir a-zakir reopened this Dec 20, 2023
@watermelon-copilot-for-code-review Watermelon - Copilot For Code Review
Copy link

watermelon-copilot-for-code-review bot commented Dec 20, 2023 •
edited
Loading

Watermelon AI Summary

AI Summary deactivated by a-zakir

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶

@watermelon-copilot-for-code-review Watermelon - Copilot For Code Review
Copy link

Watermelon AI Summary

AI Summary deactivated by a-zakir

GitHub PRs

Antares_Simulator is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

@a-zakir
Copy link
Contributor Author

a-zakir commented Dec 20, 2023

see comments in #1791

@a-zakir a-zakir requested a review from sylvlecl December 20, 2023 11:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

flomnes
flomnes reviewed Dec 28, 2023
View reviewed changes
src/solver/utils/ortools_utils.cpp
Comment on lines -218 to +245
std::ostringstream tmpPath;
tmpPath << fs::temp_directory_path().string() << Yuni::IO::SeparatorAsString << filename;
return tmpPath.str();
return (CreateRandomSubDir(std::filesystem::temp_directory_path()) / filename).string().c_str();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the behavior. How about keeping the same behavior as previously ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see Pr reviews

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we may remove the last 2 commits

@flomnes flomnes closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes left review comments

@sylvlecl sylvlecl Awaiting requested review from sylvlecl

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-zakir @flomnes