Skip to content

Commit

Permalink
Bump OR-Tools 9.2 -> 9.5, fix random compilation errors in Windows (#…
Browse files Browse the repository at this point in the history
…1167)

* Bump OR-Tools 9.2 -> 9.5

* Remove typedef struct, use C++ declarations instead

* Fix error C2445

result type of conditional expression is ambiguous: types 'const wchar_t [5]' and 'wxString' can be converted to multiple common types [D:\a\Antares_Simulator\Antares_Simulator\_build\ui\simulator\antares-8.5-ui-simulator.vcxproj]

* rte1.0 -> rte1.1

* Bump to 9.5-rte2.0

* Fix error C2445

result type of conditional expression is ambiguous: types 'const wchar_t [5]' and 'wxString' can be converted to multiple common types [D:\a\Antares_Simulator\Antares_Simulator\_build\ui\simulator\antares-8.5-ui-simulator.vcxproj]
  • Loading branch information
flomnes authored May 2, 2023
1 parent f49f912 commit f3de984
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/centos7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- name: Config OR-Tools URL
run: |
echo "URL_ORTOOLS=https://github.com/rte-france/or-tools/releases/download/v9.2-rte2.1/ortools_cxx_centos7_static_sirius.zip" >> $GITHUB_ENV
echo "URL_ORTOOLS=https://github.com/rte-france/or-tools/releases/download/v9.5-rte2.0/ortools_cxx_centos7_static_sirius.zip" >> $GITHUB_ENV
- name: Download OR-Tools
id: ortools
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonarcloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# https://sonarcloud.io/documentation/analysis/scan/sonarscanner/
SONAR_SERVER_URL: "https://sonarcloud.io"
ORTOOLS_DIR: ${{ github.workspace }}/or-tools
ORTOOLS_URL: "https://github.com/rte-france/or-tools/releases/download/v9.2-rte1.7/ortools_cxx_ubuntu-20.04_static_sirius.zip"
ORTOOLS_URL: "https://github.com/rte-france/or-tools/releases/download/v9.5-rte2.0/ortools_cxx_ubuntu-20.04_static_sirius.zip"

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:

- name: Config OR-Tools URL
run: |
echo "ORTOOLS_URL=https://github.com/rte-france/or-tools/releases/download/v9.2-rte2.1/ortools_cxx_ubuntu-20.04_static_sirius.zip" >> $GITHUB_ENV
echo "ORTOOLS_URL=https://github.com/rte-france/or-tools/releases/download/v9.5-rte2.0/ortools_cxx_ubuntu-20.04_static_sirius.zip" >> $GITHUB_ENV
- name: Download pre-compiled librairies
uses: ./.github/workflows/download-extract-precompiled-libraries-tgz
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
# Indicates the location of the vcpkg as a Git submodule of the project repository.
VCPKG_ROOT: ${{ github.workspace }}/vcpkg
ORTOOLS_DIR: ${{ github.workspace }}/or-tools
ORTOOLS_URL: "https://github.com/rte-france/or-tools/releases/download/v9.2-rte2.1/ortools_cxx_windows-latest_static_sirius.zip"
ORTOOLS_URL: "https://github.com/rte-france/or-tools/releases/download/v9.5-rte2.0/ortools_cxx_windows-latest_static_sirius.zip"

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-vcpkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
# Indicates the location of the vcpkg as a Git submodule of the project repository.
VCPKG_ROOT: ${{ github.workspace }}/vcpkg
ORTOOLS_DIR: ${{ github.workspace }}/or-tools
ORTOOLS_URL: "https://github.com/rte-france/or-tools/releases/download/v9.2-rte2.1/ortools_cxx_windows-latest_static_sirius.zip"
ORTOOLS_URL: "https://github.com/rte-france/or-tools/releases/download/v9.5-rte2.0/ortools_cxx_windows-latest_static_sirius.zip"

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion ortools_tag
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v9.2-rte2.1
v9.5-rte2.0
6 changes: 5 additions & 1 deletion src/ui/simulator/windows/simulation/run.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,11 @@ static wxString TimeSeriesToWxString(uint m)
r << (r.empty() ? wxEmptyString : wxT(", ")) << wxT("wind");
if (m & Data::timeSeriesThermal)
r << (r.empty() ? wxEmptyString : wxT(", ")) << wxT("thermal");
return r.empty() ? wxT("none") : r;

if (r.empty())
return wxT("none");
else
return r;
}

static inline void UpdateLabel(bool& guiUpdated, wxStaticText* label, const wxString& text)
Expand Down

0 comments on commit f3de984

Please sign in to comment.