Data for new modeler (4.1) : more fix due to review

AntaresSimulatorTeam · Jan 23, 2025 · 7550fc1 · 7550fc1
1 parent 5bca306
commit 7550fc1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/linearProblemData.h b/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/linearProblemData.h
@@ -39,7 +39,7 @@ class LinearProblemData: public Api::ILinearProblemData
                    const unsigned scenario,
                    const unsigned hour) override;
 
-    void addScenarioGroup(std::string groupId, std::pair<unsigned, unsigned> scenarioToRank);
+    void addScenarioGroup(const std::string& groupId, std::pair<unsigned, unsigned> scenarioToRank);
     void addDataSeries(std::unique_ptr<IDataSeries> dataSeries);
 
 private:

diff --git a/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h b/src/solver/modeler/dataSeries/include/antares/solver/modeler/dataSeries/timeSeriesSet.h
@@ -9,7 +9,7 @@ class TimeSeriesSet: public IDataSeries
 {
 public:
     explicit TimeSeriesSet(std::string name, unsigned height);
-    void add(std::vector<double> ts);
+    void add(const std::vector<double>& ts);
     double getData(unsigned rank, unsigned hour) override;
 
 private:

diff --git a/src/solver/modeler/dataSeries/linearProblemData.cpp b/src/solver/modeler/dataSeries/linearProblemData.cpp
@@ -24,7 +24,7 @@
 namespace Antares::Solver::Modeler::DataSeries
 {
 
-void LinearProblemData::addScenarioGroup(std::string groupId,
+void LinearProblemData::addScenarioGroup(const std::string& groupId,
                                          std::pair<unsigned, unsigned> scenarioToRank)
 {
     groupRepository_.addPairScenarioRankToGroup(groupId, scenarioToRank);

diff --git a/src/solver/modeler/dataSeries/timeSeriesSet.cpp b/src/solver/modeler/dataSeries/timeSeriesSet.cpp
@@ -13,7 +13,7 @@ TimeSeriesSet::TimeSeriesSet(std::string name, unsigned int height):
 {
 }
 
-void TimeSeriesSet::add(std::vector<double> ts)
+void TimeSeriesSet::add(const std::vector<double>& ts)
 {
     if (ts.size() != height_)
     {
-Original file line number
+Diff line change
@@ Expand Up @@
     {
     }
-    void TimeSeriesSet::add(std::vector<double> ts)
+    void TimeSeriesSet::add(const std::vector<double>& ts)
     {
         if (ts.size() != height_)
         {
@@ Expand Down @@