fix(study-tree-ui): fix folder loading #2325
Open
+44
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add item loading mechanic. Currently the study tree display the folders from the initial study tree, and then display folder loaded dynamically if any. This is annonying for the user as a folder can move at the time he's clicking on it.
Replace onClickNode by onItemExpansionToggle. The onClick is only applied to the text part of the tree item and not the arrow part. This is confusing for the user as the subfolders aren't loaded when the user click on an arrow, and the user is stuck with a loading message.
Disable scan on default folder as this makes no sense. The front end call the api with invalid arguments which just returns an error.