Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): add PR title lint job #2304

Merged
merged 1 commit into from
Jan 23, 2025
Merged

ci(github): add PR title lint job #2304

merged 1 commit into from
Jan 23, 2025

Conversation

skamril
Copy link
Member

@skamril skamril commented Jan 20, 2025

No description provided.

@skamril skamril self-assigned this Jan 20, 2025
@skamril skamril requested a review from MartinBelthle January 20, 2025 15:35
@skamril skamril force-pushed the feature/pr-name-lint branch 13 times, most recently from 272bc83 to aa6af6c Compare January 21, 2025 15:13
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 21, 2025
@skamril skamril force-pushed the feature/pr-name-lint branch 2 times, most recently from 88e363f to e32b879 Compare January 21, 2025 15:21
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 21, 2025
@skamril skamril force-pushed the feature/pr-name-lint branch 6 times, most recently from 54304a0 to 12badb3 Compare January 21, 2025 15:56
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 21, 2025
@skamril skamril force-pushed the feature/pr-name-lint branch from 12badb3 to 14e36ac Compare January 21, 2025 15:59
@skamril skamril changed the title ci(github): add PR name lint job ci(github) : add PR name lint job Jan 21, 2025
@skamril skamril changed the title ci(github) : add PR name lint job ci(github: add PR name lint job Jan 21, 2025
@skamril skamril force-pushed the feature/pr-name-lint branch from 14e36ac to fe32f52 Compare January 21, 2025 16:17
@skamril skamril changed the title ci(github: add PR name lint job ci(github): add PR name lint job Jan 21, 2025
@skamril skamril force-pushed the feature/pr-name-lint branch from fe32f52 to 15a3929 Compare January 21, 2025 16:19
@skamril skamril changed the title ci(github): add PR name lint job ci(github): add PR title lint job Jan 21, 2025
MartinBelthle
MartinBelthle reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. I just don't understand the change inside commitlint.js
Also it's a bit odd to use the gh action of a random dude but doesn't really matter

@skamril
Copy link
Member Author

skamril commented Jan 22, 2025 •
edited
Loading

Seems good. I just don't understand the change inside commitlint.js Also it's a bit odd to use the gh action of a random dude but doesn't really matter

I convert commitlint.config.js to a CommonJS syntax, because ES Modules is not supported by the new action.
The action doesn't use any permissions, so it's not a problem for the security.

@skamril skamril force-pushed the feature/pr-name-lint branch from 15a3929 to 5547f15 Compare January 22, 2025 09:57
@skamril skamril requested a review from MartinBelthle January 22, 2025 12:42
@skamril skamril force-pushed the feature/pr-name-lint branch from 5547f15 to c069ed8 Compare January 22, 2025 15:17
@skamril skamril force-pushed the feature/pr-name-lint branch from c069ed8 to a5cbede Compare January 22, 2025 16:23
@sylvlecl sylvlecl merged commit a7dd4ab into dev Jan 23, 2025
13 of 14 checks passed
@sylvlecl sylvlecl deleted the feature/pr-name-lint branch January 23, 2025 09:35
sylvlecl pushed a commit that referenced this pull request Jan 27, 2025
@skamril @sylvlecl
ci(github): add PR title lint job (#2304)
b730f1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvlecl sylvlecl sylvlecl approved these changes

@MartinBelthle MartinBelthle Awaiting requested review from MartinBelthle

Assignees

@skamril skamril

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skamril @sylvlecl @MartinBelthle