Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ts-gen): add links ts-generation info inside DB #2302

Open
wants to merge 53 commits into
base: dev
Choose a base branch
from
Open

feat(ts-gen): add links ts-generation info inside DB #2302

wants to merge 53 commits into from
+788 −355

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Jan 20, 2025 •
edited
Loading

Will fix [ANT-2651]

What does this PR achieves:

  • Creates 2 new tables inside the DB to store several information
    • 1 table to store for each study, how many years should be generated for the links TS-generation
    • 1 table to store the generation parameters for each link of each study
  • Add the TS generation parameters inside the response of each link endpoint
    • At the creation, the user can specify these parameters
    • At the update, the user can specify these parameters
    • These parameters can be visualized inside the table-mode
  • Handling of the variants
    • When we invalidate the cache of a variant, the 2 tables are also cleared
    • When a variant snapshot is generated, parents information inside DB are copied to ensure the information is up to date

@MartinBelthle MartinBelthle self-assigned this Jan 20, 2025
@MartinBelthle MartinBelthle force-pushed the feart/add-links-ts-info-inside-db branch from c6abd00 to 18eed3c Compare January 21, 2025 16:16
@MartinBelthle MartinBelthle changed the title feat(ts-gen): add ts generation info inside DB feat(ts-gen): add links ts-generation info inside DB Jan 22, 2025
@MartinBelthle MartinBelthle force-pushed the feart/add-links-ts-info-inside-db branch from 54ee492 to 19b2ccf Compare January 22, 2025 17:32
@MartinBelthle MartinBelthle marked this pull request as ready for review January 22, 2025 17:37
@MartinBelthle MartinBelthle force-pushed the feart/add-links-ts-info-inside-db branch from 7f4a208 to ab2f3ce Compare January 27, 2025 15:32
sylvlecl
sylvlecl reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@sylvlecl sylvlecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

alembic/versions/dadad513f1b6_create_links_ts_generation_tables.py Show resolved Hide resolved
antarest/study/storage/variantstudy/variant_study_service.py Outdated Show resolved Hide resolved
antarest/study/storage/variantstudy/variant_study_service.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvlecl sylvlecl Awaiting requested review from sylvlecl

@TheoPascoli TheoPascoli Awaiting requested review from TheoPascoli

At least 1 approving review is required to merge this pull request.

Assignees

@MartinBelthle MartinBelthle

Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinBelthle @sylvlecl