Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ui): add cypress tests to github actions #2285

Open
wants to merge 73 commits into
base: dev
Choose a base branch
from

Conversation

TheoPascoli
Copy link
Contributor

No description provided.

@TheoPascoli TheoPascoli changed the title test: first commit to add cypress tests to github actions test: add cypress tests to github actions Jan 8, 2025
@TheoPascoli TheoPascoli marked this pull request as draft January 8, 2025 15:53
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 9, 2025
@TheoPascoli TheoPascoli requested a review from skamril January 24, 2025 14:26
@@ -25,6 +25,7 @@
"@reduxjs/toolkit": "1.9.6",
"axios": "1.7.7",
"clsx": "2.1.1",
"cypress": "13.17.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to devDependencies

@@ -21,6 +21,7 @@ import jsdocPlugin from "eslint-plugin-jsdoc";
import prettierPluginRecommended from "eslint-plugin-prettier/recommended";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only add this line:

cypressPlugin.configs.recommended,

before

prettierPluginRecommended, // Must be the last one

It includes all.

@@ -25,6 +25,7 @@
"@reduxjs/toolkit": "1.9.6",
Copy link
Member

@skamril skamril Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a npm script for cypress

@@ -0,0 +1,15 @@
/**
Copy link
Member

@skamril skamril Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use .ts for all test files instead to support TypeScript

@skamril skamril changed the title test: add cypress tests to github actions test(ui): add cypress tests to github actions Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants