chore(commands): fix user name display in commands #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvlecl
requested changes
Jan 8, 2025
There was a problem hiding this comment.
I think we should have a slightly more generic approach so that all tasks fill the _current_user context var, see comments.
Later, this will ensure that all tasks have the current user available, not only TS generation tasks. This will also simplify the implementation of execute_or_add_commands
sylvlecl
reviewed
Jan 8, 2025
maugde
force-pushed
the
fix/ANT-2543-fix-user-name-display-in-commands
branch
from
ba13afe to
c37e3c0
Compare
maugde
force-pushed
the
fix/ANT-2543-fix-user-name-display-in-commands
branch
2 times, most recently
from
e0fa0f6 to
63e4baa
Compare
sylvlecl
requested changes
Jan 13, 2025
…ent user identity, update execute_or_add_commands function, update tests
…riesGeneratorTask, add context manager, update test
maugde
force-pushed
the
fix/ANT-2543-fix-user-name-display-in-commands
branch
from
63e4baa to
bfcd7aa
Compare
sylvlecl
approved these changes
Jan 15, 2025
TheoPascoli
approved these changes
Jan 16, 2025
smailio
pushed a commit
that referenced
this pull request
Jan 17, 2025
A context variable is introduced to hold the use of the current request, and of the current task. Can be re-used in the future to avoid passing this context information as an argument to all methods (for logging, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ANT-2543