feat(launcher): add new API endpoint /v1/launcher/time-limit and update LauncherDialog
#2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent-laporte-pro
added
bug
skamril
requested changes
Apr 29, 2024
skamril
requested changes
Apr 29, 2024
|
I think the back-end should call this new endpoint inside the |
|
As stated in this issue: #1783 The API endpoints related to this form should be consolidated into one, that returns a structured json with all the necessary data like launcher versions, nb cpu, time limit, outputs list etc. |
hdinia
requested changes
May 6, 2024
hdinia
force-pushed
the
feature/handle-time-limit-launcher
branch
from
e15b830 to
bd98824
Compare
skamril
requested changes
May 22, 2024
skamril
requested changes
May 22, 2024
skamril
requested changes
May 22, 2024
…min`, `defaultValue` and `max`
…`, `defaultValue` and `max` values
skamril
approved these changes
May 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces a new API endpoint,
/v1/launcher/time-limit, which retrieves the time limit for a job (in seconds) for a given launcher: "local" or "slurm". The value is read from theapplication.yamlconfiguration file.In addition, the
LauncherDialoghas been updated to use this endpoint to initialize the default and maximum values for thetimeLimitfield. The minimum value is set to 3600 seconds. The time limit is displayed in hours, with a step of 1 hour.This enhancement provides a more dynamic and configurable approach to setting the time limit for jobs, allowing for greater flexibility and control in job execution.