Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(synthesis): prevent 500 error during study synthesis parsing #2011

Merged

Conversation

laurent-laporte-pro
Copy link
Contributor

Description:

This pull request addresses an issue encountered during the parsing of a study's synthesis. Previously, if the configuration files for an area were missing or empty, the system would throw a 500 error. This behavior is not ideal as it interrupts the flow of the application and may cause confusion for the users.

We have implemented a solution to return a default configuration when the area's configuration files are missing or empty. This ensures that the application can continue to function smoothly, improving the overall user experience.

Changes include:

  • Added checks to verify the existence and content of area configuration files during the parsing process.
  • Implemented a default configuration that is returned when the area's configuration files are missing or empty.

@laurent-laporte-pro laurent-laporte-pro self-assigned this Apr 17, 2024
@laurent-laporte-pro laurent-laporte-pro added bug Something isn't working hot back-end labels Apr 17, 2024
@laurent-laporte-pro laurent-laporte-pro requested review from mabw-rte and removed request for MartinBelthle April 17, 2024 09:46
@laurent-laporte-pro laurent-laporte-pro force-pushed the hotfix/v2.16.8-optimization-filtering branch from a70afd2 to aef1828 Compare April 17, 2024 09:51
mabw-rte
mabw-rte previously approved these changes Apr 18, 2024
@laurent-laporte-pro laurent-laporte-pro dismissed mabw-rte’s stale review April 19, 2024 11:32

The merge-base changed after approval.

@laurent-laporte-pro laurent-laporte-pro added this to the v2.16.8 milestone Apr 19, 2024
@laurent-laporte-pro laurent-laporte-pro force-pushed the hotfix/v2.16.8-optimization-filtering branch from aef1828 to 59c14b9 Compare April 19, 2024 14:12
@laurent-laporte-pro laurent-laporte-pro merged commit b618c7d into hotfix/v2.16.8 Apr 19, 2024
7 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the hotfix/v2.16.8-optimization-filtering branch April 19, 2024 14:12
@laurent-laporte-pro laurent-laporte-pro mentioned this pull request Apr 19, 2024
17 tasks
@skamril skamril mentioned this pull request Apr 19, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end bug Something isn't working hot size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants