-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bc): better handling of default values #2004
fix(bc): better handling of default values #2004
Conversation
antarest/study/storage/variantstudy/model/command/create_binding_constraint.py
Show resolved
Hide resolved
antarest/study/storage/variantstudy/model/command/create_binding_constraint.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where those __getattribute__
comes from, but it is a bad practice. We should use getattr()
function instead.
modify the constraint term to remove optional values |
89d87a7
to
daad91b
Compare
There's an issue with the removal of constraint terms. |
daad91b
to
7198064
Compare
2810609
to
07b6329
Compare
@laurent-laporte-pro I've checked your commit and I think you should revert it because you missed this part of the code that makes your test fail inside the old
So IMO we should not touch at this code as it would mean a big refactoring for other commands and we do not want that in this PR |
c8195fc
to
84d2b7a
Compare
4922187
to
6f0a2c7
Compare
6f0a2c7
to
e70dae6
Compare
I've done a rollback + refactoring. It's OK now. |
…flowByCluster` is removed)
This pull request significantly enhances the management of default values when using the
create_binding_constraint
andupdate_binding_constraint
commands. It also addresses an issue with updating terms of a binding constraint using theupdate_binding_constraint
command.Corrections have also been made to the
CommandExtractor
class, which extracts commands from a base study and a modified study through comparison, and to theCommandReverter
class, which reverses commands based on a command history.The generation of a study from a list of commands has been corrected: now, the generation stops as soon as an error is encountered, making it easier to identify the failing command, as it is necessarily the last one executed.