-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xpansion): update for improved parameter handling and code refactoring #1865
Conversation
-
to _
in relative_optimality_gap parameter
12d2fb4
to
7878fac
Compare
NB : I've requested a review from Hatim concerning the little front-end part and from Laurent for the back-end part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Thomas' specification documentation, the relaxed_optimality_gap
should exist in version >= 800. The default value is 1e-5.
There is a similar issue with the field relative_gap
which has the default value 1e-6.
antarest/study/storage/rawstudy/model/filesystem/root/user/expansion/settings.py
Outdated
Show resolved
Hide resolved
6762fbc
to
de3ebd6
Compare
98e3b2e
to
0b51fdf
Compare
0b51fdf
to
638e046
Compare
638e046
to
b3ea9d7
Compare
-
to _
in relative_optimality_gap parameter
@skamril, Thomas B. nous a fourni des spécifications concernant le formulaire de configuration générales d'Xpansion Actuellement, ce formulaire est soumis de manière globale, ce qui correspond bien à une requête PUT. Mais je remarque Donc, pour palier à ce problème, j'ai rendu les attributs J'ai fait ma propre analyse de la situation : lorsque l'utilisateur sélectionne l'option "Aucun" dans la liste, Cela est fait dans le script <MenuItem key="None" value="">
{t("global.none")}
</MenuItem> Ce qui est différent de |
… and update labels
…lds into mandatory fields
b3ea9d7
to
d2b2985
Compare
Changes Proposed:
Change "-" to "_" in
relative_optimality_gap
parameter:relative_optimality_gap
parameter for consistency:drop the
relative-optimality-gap
parameter in the backend and the front end)Removal of obsolete fields related to r version of Xpansion:
Improvement of field labels for better user comprehension:
Add constraints for numeric fields:
Backend enhancement for empty strings in "additional-constraints" and "yearly-weights" parameters:
not included in PUT requests from the frontend. This allows the user to unselect a file.
Code refactoring for improved maintenance:
Testing:
Notes for Reviewers: