Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tasks): resolve incorrect UTC timezone usage for task completion dates in list view #1786

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix(tasks): resolve incorrect UTC timezone usage for task completion dates in list view #1786

merged 2 commits into from
Nov 13, 2023

Conversation

laurent-laporte-pro
Copy link
Contributor

@laurent-laporte-pro laurent-laporte-pro commented Oct 26, 2023 •
edited
Loading

This PR correct the way completion_date is updated at the end of task processing.

wrong-completion-date-in-task-view

The task list in the study main view is also fixed:

study_view-completion_date-corrected

@laurent-laporte-pro laurent-laporte-pro self-assigned this Oct 26, 2023
@commit-lint
Copy link

commit-lint bot commented Oct 26, 2023 •
edited
Loading

Bug Fixes

  • task-view: do not use the timezone.utc timezone to preserve a naive datetime (ac80781)
  • matrix-service: do not use the timezone.utc timezone to preserve a naive datetime (9b62e0e)

Contributors

laurent-laporte-pro

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@laurent-laporte-pro laurent-laporte-pro linked an issue Oct 26, 2023 that may be closed by this pull request
Invalid completion date in task view #1785
Closed
@laurent-laporte-pro laurent-laporte-pro force-pushed the hotfix/correct-completion_date-value branch from a3f0f5e to 17eb15f Compare October 27, 2023 05:49
@laurent-laporte-pro laurent-laporte-pro changed the title fix(task-view): do not use the timezone.utc timezone to preserve a naive datetime fix(tasks): resolve incorrect UTC timezone usage for task completion dates in list view Oct 27, 2023
@laurent-laporte-pro laurent-laporte-pro requested review from MartinBelthle and removed request for hdinia November 6, 2023 10:22
@MartinBelthle MartinBelthle force-pushed the hotfix/correct-completion_date-value branch from 17eb15f to ecc37bd Compare November 6, 2023 12:38
@laurent-laporte-pro laurent-laporte-pro force-pushed the hotfix/correct-completion_date-value branch 2 times, most recently from 688842a to a5a8373 Compare November 11, 2023 13:38
@laurent-laporte-pro laurent-laporte-pro force-pushed the hotfix/correct-completion_date-value branch from a5a8373 to 9b62e0e Compare November 11, 2023 13:48
@laurent-laporte-pro laurent-laporte-pro merged commit 1f23998 into release/2.15.5 Nov 13, 2023
@laurent-laporte-pro laurent-laporte-pro deleted the hotfix/correct-completion_date-value branch November 13, 2023 15:47
@commit-lint commit-lint bot mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBelthle MartinBelthle MartinBelthle approved these changes

Assignees

@laurent-laporte-pro laurent-laporte-pro

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid completion date in task view
2 participants
@laurent-laporte-pro @MartinBelthle