Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log-parser): simplify parsing and make it accurate #1682

Merged
merged 5 commits into from
Aug 2, 2023
Merged

fix(log-parser): simplify parsing and make it accurate #1682

merged 5 commits into from
Aug 2, 2023

Conversation

MartinBelthle
Copy link
Contributor

No description provided.

@MartinBelthle MartinBelthle self-assigned this Jul 28, 2023
@commit-lint
Copy link

commit-lint bot commented Jul 28, 2023 •
edited
Loading

Contributors

MartinBelthle, laurent-laporte-pro

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@MartinBelthle MartinBelthle linked an issue Jul 28, 2023 that may be closed by this pull request
Job progress can exceed 100% #1681
Closed
laurent-laporte-pro
laurent-laporte-pro suggested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@laurent-laporte-pro laurent-laporte-pro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cette branche n'est plus à jour suite au revert de dev 😕

antarest/launcher/adapters/log_parser.py Outdated Show resolved Hide resolved
antarest/launcher/adapters/log_parser.py Outdated Show resolved Hide resolved
antarest/launcher/adapters/log_parser.py Outdated Show resolved Hide resolved
antarest/launcher/adapters/log_parser.py Outdated Show resolved Hide resolved
antarest/study/common/studystorage.py Outdated Show resolved Hide resolved
tests/launcher/test_log_parser.py Outdated Show resolved Hide resolved
tests/launcher/test_log_parser.py Outdated Show resolved Hide resolved
tests/launcher/test_log_parser.py Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XL and removed size/M labels Aug 1, 2023
@laurent-laporte-pro laurent-laporte-pro force-pushed the fix/job_progress_can_exceed_100_prct branch from 29e9148 to 7d95661 Compare August 1, 2023 21:37
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Aug 1, 2023
@laurent-laporte-pro laurent-laporte-pro force-pushed the fix/job_progress_can_exceed_100_prct branch 2 times, most recently from 6f5a2b1 to a4ae2d1 Compare August 1, 2023 21:41
@laurent-laporte-pro laurent-laporte-pro force-pushed the fix/job_progress_can_exceed_100_prct branch from a4ae2d1 to 40154ae Compare August 2, 2023 13:12
@laurent-laporte-pro laurent-laporte-pro marked this pull request as draft August 2, 2023 13:14
@laurent-laporte-pro laurent-laporte-pro marked this pull request as ready for review August 2, 2023 14:30
@laurent-laporte-pro laurent-laporte-pro changed the title fix(log_parser): simplify parsing and make it accurate fix(log-parser): simplify parsing and make it accurate Aug 2, 2023
@laurent-laporte-pro laurent-laporte-pro force-pushed the fix/job_progress_can_exceed_100_prct branch from f71efc5 to dca1cd3 Compare August 2, 2023 19:41
@laurent-laporte-pro laurent-laporte-pro merged commit b00e755 into dev Aug 2, 2023
@laurent-laporte-pro laurent-laporte-pro deleted the fix/job_progress_can_exceed_100_prct branch August 2, 2023 20:01
laurent-laporte-pro added a commit that referenced this pull request Aug 2, 2023
@MartinBelthle @laurent-laporte-pro
fix(log-parser): simplify parsing and make it accurate (#1682)
5d20d6d 
Co-authored-by: Laurent LAPORTE <[email protected]>
@commit-lint commit-lint bot mentioned this pull request Aug 2, 2023
Merged
laurent-laporte-pro added a commit that referenced this pull request Aug 2, 2023
@MartinBelthle @laurent-laporte-pro
fix(log-parser): simplify parsing and make it accurate (#1682)
2442674 
Co-authored-by: Laurent LAPORTE <[email protected]>
@commit-lint commit-lint bot mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurent-laporte-pro laurent-laporte-pro laurent-laporte-pro approved these changes

Assignees

@MartinBelthle MartinBelthle

Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Job progress can exceed 100%
2 participants
@MartinBelthle @laurent-laporte-pro