-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/1646 refactoring request for study function #1669
Merged
TLAIDI
merged 13 commits into
dev
from
features/1646-Refactoring-request-for-study-function
Jul 26, 2023
+155
−165
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
adcb2d0
Refactor(export) : Refactoring request for Study export function (#1646)
10e08cd
Refactor(export): clean code by removing comments and duplicate code
e4290a8
Refactor(export): fix litle bug
0154d6b
Refactor(export) : add a litle refactoring (#1646)
f0b9798
Refactor(export) : fix tests units (#1646)
c3ee12a
Refactor(export) : fix tests units: test_variant_model.py::test_comma…
911ad2e
Refactor(export) : fix tests units: test_variant_model.py::test_smart…
1c0718c
Refactor(export) : fix mypy (#1646)
a5a75d0
Refactor(export) : fix mypy again (#1646)
d472a2e
Merge branch 'dev' into features/1646-Refactoring-request-for-study-f…
TLAIDI 78332b0
refactor(export): add some improvement
950ddd8
Merge branch 'features/1646-Refactoring-request-for-study-function' o…
ab8b2ce
refactor(export): add again some improvement
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Refactor(export): clean code by removing comments and duplicate code
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant rawstudy. To avoid this type of confusion, we usually do this in the code :
if isinstance(target_study, RawStudy):