Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve fixtures in unit tests for better reuse #1638

Merged
merged 3 commits into from
Jul 4, 2023
Merged

test: improve fixtures in unit tests for better reuse #1638

merged 3 commits into from
Jul 4, 2023

Conversation

laurent-laporte-pro
Copy link
Contributor

Cette PR améliore et document les fixtures dans les tests unitaire afin d'en améliorer la ré-utilisabilité, notamment en ce qui concerne la gestion des matrices.

@laurent-laporte-pro laurent-laporte-pro added technical story Technical story testing story create an integration test to valide a behavior labels Jun 30, 2023
@laurent-laporte-pro laurent-laporte-pro self-assigned this Jun 30, 2023
@commit-lint
Copy link

commit-lint bot commented Jun 30, 2023 •
edited
Loading

Tests

  • matrix: add missing docstring of some fixtures (c1a8bc1)
  • matrix: Improve and document the service_fixture fixture for generating unique matrix IDs (9f97b90)
  • move wait_task_completion function in utils.py for better reuse (4febd1d)

Contributors

laurent-laporte-pro

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@laurent-laporte-pro laurent-laporte-pro linked an issue Jun 30, 2023 that may be closed by this pull request
[ANT-706] Add ST-storage (variant) commands #1629
Closed
@laurent-laporte-pro laurent-laporte-pro force-pushed the feature/1629-improve-unit-tests branch from 7ab0330 to 4febd1d Compare July 4, 2023 11:55
@laurent-laporte-pro laurent-laporte-pro merged commit b763ede into dev Jul 4, 2023
@laurent-laporte-pro laurent-laporte-pro deleted the feature/1629-improve-unit-tests branch July 4, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdinia hdinia hdinia approved these changes

@skamril skamril Awaiting requested review from skamril

Assignees

@laurent-laporte-pro laurent-laporte-pro

Labels
size/L technical story Technical story testing story create an integration test to valide a behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ANT-706] Add ST-storage (variant) commands
2 participants
@laurent-laporte-pro @hdinia