Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: the section name in the INI file is the cluster ID, not the cluster name #1634

Closed
wants to merge 1 commit into from

Conversation

laurent-laporte-pro
Copy link
Contributor

@laurent-laporte-pro laurent-laporte-pro commented Jun 30, 2023

Cette PR, actuellement en mode "brouillon", a pour objectif de corriger la confusion qu'il y a actuellement entre l'ID et le nom d'un cluster thermique ou renouvelable.

En effet, dans la configuration (le fichier list.ini), la section représente l'identifiant du cluster alors que l'option name représente le nom. Il va s'en dire que l'on peut facilement passer du nom à l'ID en utilisant la fonction transform_name_to_id (mais pas dans l'autre sens).

[sb]           # <- Cluster ID
name = sb      # <- Cluster Name
group = Gas
unitcount = 25
nominalcapacity = 500.000000
co2 = 0.900000
marginal-cost = 50.000000
market-bid-cost = 50.000000

@commit-lint
Copy link

commit-lint bot commented Jun 30, 2023

Chore

  • the section name in the INI file is the cluster ID, not the cluster name (5994902)

Contributors

laurent-laporte-pro

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@laurent-laporte-pro
Copy link
Contributor Author

Cette anomalie est contournée en considérant que le nom de la section est un ID insensible à la case. Autrement dit, le nom de la section peut être le nom du cluster (aux caractères spéciaux près).

Résolu lors du refactoring de la version v2.16

@laurent-laporte-pro laurent-laporte-pro deleted the feature/1629-code-review branch November 11, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant