Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): add ST-Storage commands #1630

Merged
merged 13 commits into from
Jul 18, 2023

Conversation

laurent-laporte-pro
Copy link
Contributor

@laurent-laporte-pro laurent-laporte-pro commented Jun 28, 2023

L'objectif de cette PR est d'ajouter les commandes CreateSTStorage et RemoveSTStorage nécessaires à la gestion des stockages court terme.

La gestion des matrices a été modifié pour ajouter les séries temporelles nécessaires aux stockages court terme.

L'implémentation de ces commandes nécessite un refactoring d'autres commandes comme la creation de zones, les cluster thermiques et renouvelable. Le refactoring vise principalement à améliorer l'implémentation ou le style de programmation afin d'en réduire la complexité (surconception).

Une confusion a été repérée entre les noms et les IDs des clusters thermiques et renouvelable. Ces anomalies sont signalées avec des # fixme facilement repérables dans le code. Elles ne sont pas corrigées, cela ferra l'objet d'une issue/PR.

Cette PR met aussi à jour la liste des commandes dans la documentation. À ce niveau, il y a encore du travail à faire, mais cela ferra l'objet d'une autre User Story.

On a aussi ajouté de la documentation dans le code source (doccstrings) afin d'améliorer la maintenabilité et la compréhension du code pour les développeurs.

@laurent-laporte-pro laurent-laporte-pro self-assigned this Jun 28, 2023
@commit-lint
Copy link

commit-lint bot commented Jun 28, 2023

Chore

  • the section name in the INI file is the cluster ID, not the cluster name (5c0b195)

Code Refactoring

  • model: use the phrasing "st_storage" instead of "storage" to avoid confusion (43fc3f2)
  • introduce _MATRIX_NAMES to enumerate all matrix names (bf6b1b3)
  • directly access the methods instead of using getattr for maintainability (90c9747)

Features

  • matrix: define ST Storage matrices in the GeneratorMatrixConstants class (7f63828)
  • storage: implement the CreateSTStorage and RemoveSTStorage commands (578d783)
  • command: handle the CreateSTStorage and RemoveSTStorage commands in the commands factory (993fbcb)
  • storage: improve the CreateSTStorage and RemoveSTStorage commands (625fd95)
  • change the regex used to allow uppercase letters in storage IDs (b3780a6)
  • change the path used to access TS files (49abf44)

Documentation

  • variant: upgrade the "Variant Manager" topic to add short-term storage (86b74ec)

Tests

Bug Fixes

  • typing: fix redundant cast to "str" (b7d755c)

Contributors

laurent-laporte-pro

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@laurent-laporte-pro laurent-laporte-pro linked an issue Jun 29, 2023 that may be closed by this pull request
@laurent-laporte-pro laurent-laporte-pro force-pushed the feature/1525-add-st-storage-commands branch from 39e6274 to 7818832 Compare June 29, 2023 13:43
@laurent-laporte-pro laurent-laporte-pro requested review from hdinia and removed request for hdinia June 29, 2023 13:47
@laurent-laporte-pro laurent-laporte-pro marked this pull request as draft June 29, 2023 22:16
@laurent-laporte-pro laurent-laporte-pro force-pushed the feature/1525-add-st-storage-commands branch 4 times, most recently from 4e416ba to 1738100 Compare July 4, 2023 13:24
@laurent-laporte-pro laurent-laporte-pro force-pushed the feature/1525-add-st-storage-commands branch from 1738100 to 5f2feaa Compare July 12, 2023 07:31
@laurent-laporte-pro laurent-laporte-pro marked this pull request as ready for review July 12, 2023 07:31
@laurent-laporte-pro laurent-laporte-pro force-pushed the feature/1525-add-st-storage-commands branch from 8409043 to b7d755c Compare July 18, 2023 10:15
@laurent-laporte-pro
Copy link
Contributor Author

I've just switched my feature branch to the development branch to take into account the update regarding the use of Antares Solver 8.6.1.

Copy link
Member

@sylvlecl sylvlecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just raising some design question for future improvements.

@laurent-laporte-pro laurent-laporte-pro merged commit e88d4ee into dev Jul 18, 2023
@laurent-laporte-pro laurent-laporte-pro deleted the feature/1525-add-st-storage-commands branch July 18, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ANT-706] Add ST-storage (variant) commands
2 participants