-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commands): add ST-Storage commands #1630
Merged
laurent-laporte-pro
merged 13 commits into
dev
from
feature/1525-add-st-storage-commands
Jul 18, 2023
Merged
feat(commands): add ST-Storage commands #1630
laurent-laporte-pro
merged 13 commits into
dev
from
feature/1525-add-st-storage-commands
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore
Code Refactoring
Features
Documentation
Tests
Bug Fixes
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
39e6274
to
7818832
Compare
4e416ba
to
1738100
Compare
1738100
to
5f2feaa
Compare
…o avoid confusion
…mands in the commands factory
8409043
to
b7d755c
Compare
I've just switched my feature branch to the development branch to take into account the update regarding the use of Antares Solver 8.6.1. |
sylvlecl
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just raising some design question for future improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L'objectif de cette PR est d'ajouter les commandes
CreateSTStorage
etRemoveSTStorage
nécessaires à la gestion des stockages court terme.La gestion des matrices a été modifié pour ajouter les séries temporelles nécessaires aux stockages court terme.
L'implémentation de ces commandes nécessite un refactoring d'autres commandes comme la creation de zones, les cluster thermiques et renouvelable. Le refactoring vise principalement à améliorer l'implémentation ou le style de programmation afin d'en réduire la complexité (surconception).
Une confusion a été repérée entre les noms et les IDs des clusters thermiques et renouvelable. Ces anomalies sont signalées avec des
# fixme
facilement repérables dans le code. Elles ne sont pas corrigées, cela ferra l'objet d'une issue/PR.Cette PR met aussi à jour la liste des commandes dans la documentation. À ce niveau, il y a encore du travail à faire, mais cela ferra l'objet d'une autre User Story.
On a aussi ajouté de la documentation dans le code source (doccstrings) afin d'améliorer la maintenabilité et la compréhension du code pour les développeurs.