Fix disappearing favorites by removing favorites update on studies fetch

Signed-off-by: Paul Bui-Quang <[email protected]>
AntaresSimulatorTeam · Jun 20, 2022 · ef8cad9 · ef8cad9
1 parent e56a4b4
commit ef8cad9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/webapp/src/redux/ducks/studies.ts b/webapp/src/redux/ducks/studies.ts
@@ -211,18 +211,6 @@ export const fetchStudies = createAsyncThunk<
 >(n("FETCH_STUDIES"), async (_, { dispatch, getState, rejectWithValue }) => {
   try {
     const studies = await api.getStudies();
-    const state = getState();
-    const currentFavorites = getFavoriteStudyIds(state);
-    const newFavorites = R.innerJoin(
-      (fav, study) => fav === study.id,
-      currentFavorites,
-      studies
-    );
-
-    if (currentFavorites.length !== newFavorites.length) {
-      dispatch(setFavoriteStudies(newFavorites));
-    }
-
     dispatch(fetchStudyVersions());
 
     return studies;

diff --git a/webapp/src/redux/ducks/studyDataSynthesis.ts b/webapp/src/redux/ducks/studyDataSynthesis.ts
@@ -61,13 +61,19 @@ export const createStudyData = createAsyncThunk<
 
       // Set current area
       const areas = Object.keys(studyData.areas);
-      if (areas.length > 0) dispatch(setCurrentArea(areas[0]));
+      if (areas.length > 0) {
+        dispatch(setCurrentArea(areas[0]));
+      } else {
+        dispatch(setCurrentArea(""));
+      }
 
       // Set current link
       const links = selectLinks(studyData);
       const linkList = links ? Object.values(links) : [];
       if (linkList.length > 0) {
         dispatch(setCurrentLink(linkList[0].name));
+      } else {
+        dispatch(setCurrentLink(""));
       }
 
       return studyData;