Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asterisk Manager #572

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

Asterisk Manager #572

wants to merge 21 commits into from

Conversation

Suifu
Copy link

@Suifu Suifu commented Mar 13, 2019

Based on 558
Asterisk Manager needs some care,
but the wiki part seems to be fine (GitHub doesn't support pull requests for the wiki repository, only the main repository) example.
Regard

@kevdagoat
Copy link
Contributor

Could you please allow modifications so this PR can be modified?

@kevdagoat
Copy link
Contributor

Would like to fix some English

@Ghost9090
Copy link

@Ansuel

@FrancYescO
Copy link
Collaborator

I see better splitting this in 2 PR as asterisk and the wiki are totally different things

@Suifu
Copy link
Author

Suifu commented Mar 19, 2019

Hello thank to all for the interest,
FrancYescO i don't think the division is needful because the tab is not seen if there is no asterisk (however the commits concerned are e6855fa and 19eb209).
Thanks to kevdagoat for correct my misspelling (some are really stupid), only one thing: into 42b9f6c are you sure that is correct to remove line 26 (Wait WITHOUT TURNING OFF).
Regard

@FrancYescO
Copy link
Collaborator

about asterisk we can also add it as an extension app and the modal will be placed only when installed

@FrancYescO
Copy link
Collaborator

can be useful for the wiki: https://github.com/dirkfeytons/transformer/wiki

@Suifu
Copy link
Author

Suifu commented Mar 21, 2019

FrancYescO > about asterisk we can also add it as an extension app and the modal will be placed only when installed
Yes, this is a good idea, i have only touched voice for now
FrancYescO > can be useful for the wiki: https://github.com/dirkfeytons/transformer/wiki
Yes, we can add a "technical section" that explains how the various parts work, there are other useful Repositories inside dirkfeytons.
Thanks for the report.

@Ansuel Ansuel force-pushed the master branch 12 times, most recently from 450b70e to 7a0a91c Compare April 16, 2019 20:07
@Ansuel Ansuel force-pushed the master branch 3 times, most recently from ded837c to ec8220f Compare February 29, 2020 14:14
@Ansuel Ansuel force-pushed the master branch 8 times, most recently from 7cc0405 to 083ebd4 Compare April 18, 2020 13:25
@Ansuel Ansuel force-pushed the master branch 18 times, most recently from 7634753 to c99ffb6 Compare November 14, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants