Old API URL doesn't work anymore. Here is a workaround.#28
Open
blahem wants to merge 3 commits intoAndrewRPorter:masterfrom
Open
Old API URL doesn't work anymore. Here is a workaround.#28blahem wants to merge 3 commits intoAndrewRPorter:masterfrom
blahem wants to merge 3 commits intoAndrewRPorter:masterfrom
Conversation
api url changed: now results are given in json format. adj close column doesn't exist anymore.
Contributor
Author
|
Hello, could we finally merge this after over 10 months? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old API URL does not work anymore (https://query1.finance.yahoo.com/v7/finance/download/%s?period1=%s&period2=%s&interval=%s&events=%s)
However, this URL works : https://query2.finance.yahoo.com/v8/finance/chart/%s?period1=%s&period2=%s&interval=%s&events=%s
The difference is that the new URL returns the data in JSON format. I made sure that fetch.py can interpret the response, so yahoo-historical can work just as fine as before.
blahem.