Development #172
Open
Development #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielecook
reviewed
Apr 3, 2021
| <div class='row'> | ||
| <div class='col-md-4'> | ||
| <strong> Dataset: </strong> | ||
| </div> <!-- /col-md-4 --> |
There was a problem hiding this comment.
If you use {# #} these will be removed before being sent to the user. Not a big deal really just FYI.
danielecook
reviewed
Apr 3, 2021
|
|
||
| <div class="row"> | ||
| <div class="col-md-12"> | ||
| <table> |
There was a problem hiding this comment.
You can format this and make it look a lot nicer by adding class="table"
danielecook
approved these changes
Apr 3, 2021
|
|
||
| <div class="row"> | ||
| <div class="col-md-12"> | ||
| <table> |
There was a problem hiding this comment.
Consider adding class="table"
base/templates/download.html
Outdated
|
|
||
| <script> | ||
| $(document).ready(function() { | ||
| $('#download-link').get(0).click(); |
There was a problem hiding this comment.
This is probably a good idea. There is a 'download_bams_script.sh' page that no longer works:
We can either (1) have users request access or (2) allow users to download with a 'requester pays' option setup on GCP. This would allow users to download the data but they would have to pay for the download costs.
write bam_bai download script to cloud bucket
Feature/indel primer
Feature/indel primer
remove jwt-csrf and revise text content
update decrypt key
log exception
use service account to init bucket client
Hotfix/downloads
…n-mti/CeNDR-1 into feature/indel-primer
Version 1.7.0g
Feature/git submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Northwestern MTI release