Skip to content
This repository was archived by the owner on Jan 4, 2022. It is now read-only.

Save old title keys and info if download fails #8

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Huntereb
Copy link

If the downloading of info.json or FreeShopNX.txt fails, don't delete the files we already have.

AnalogMan151 and others added 9 commits August 30, 2018 13:02
Few small changes for cleaning purpose
Scene system is now a polymorphic class so that inputs are not globally
checked, but locally to the scene it self. This mean less complexity and
les CPU cycles wasted.

Added a special handling for the svcSleepThread function that fails to
be linked inside a virtual method, don't know why.

Bug: #1

Change-Id: I26ef85b254ec5e5773d81b4c4573670839d9ca94
Modern compilers can make use of C++17 instead of C++11 which allow some
performance improvements and some better syntaxes.

Change-Id: I8e0009ebd6140714ddb21b0e824e77c471dba051
Removed the common.hpp file, each files now includes only what it is
using.
Created a struct that represent a frame and removed the use of globals
for it.

Bug: #1

Change-Id: If2aeda2038753aebd057c278851817bbe9e31650
Reworked the scene system to be more C++ style
If the downloading of info.json or FreeShopNX.txt fails, don't delete the files we already have.
@Huntereb
Copy link
Author

I'm uncertain the exact reason, but downloading the titles before the info.json causes the information not to refresh automatically. I was able to fix it by downloading the titles after the info, but that's certainly not a proper way of doing it.

@ctxnop
Copy link
Contributor

ctxnop commented Sep 27, 2018

Keeping previous files in case of a download failure is a good ideas. I'll add it in my version.
But the other commit just work around the real issue which is the loading algorithm that assume titles should be present in the info file no matter what, and the keys should be loaded after that, adding them to existing titles.
I'm going to change that so this should not happen anymore, to handle the case that info fails to download.

@Huntereb
Copy link
Author

Not sure if this project is still alive with the recent changes to the CDN, but I have reverted the last commit as requested.

@ctxnop
Copy link
Contributor

ctxnop commented Sep 30, 2018

I'm still working on it, so it's is still alive. But unfortunatly you may be right. I can't install any other title for now. Still not sure why, I have some strange behaviour. If you have any pointer to the CDN changes you are referring to, It would be appreciated that you share them.

Meanwhile, your change was merge in my fork: https://github.com/ctxnop/FreeShopNX/commit/42279eefdfd9cf50ea52386c2e4d799af015daf7

@Huntereb
Copy link
Author

Apparently any downloads from the CDN, even game updates, now rely on dauth for account authentication. We'd require some form of exploitation of Nintendo's server infrastructure in order to bypass this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants