Merged
Conversation
These are not super useful because they only return true if they are exactly equal but they are here for completeness.
I was initially trying to make the selection classes immutable but have decided to make them mutable and return copies where the data needs to be immutable.
The shape group is now mutable and stores shared pointers to allow the vector to be resized without breaking the link to python. Redesign constructors. Add copy constructor. Add deep copy constructor. Add some mutating methods to python bindings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make SelectionShapeGroup mutable. Change storage to shared_ptr.
Implement serialisation system for shapes.
Add equality operators.
Add default constructors to shape classes.
Make matrix in shapes mutable.
Add copy and deep copy functions to SelectionShapeGroup.
Refactor and add SelectionShapeGroup tests.