Skip to content

SentryApi + GET /v5/campaign/list route tests #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2022
Merged

SentryApi + GET /v5/campaign/list route tests #488

merged 1 commit into from
Apr 13, 2022

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Apr 11, 2022

No description provided.

@simzzz simzzz requested a review from elpiel April 12, 2022 10:47
elpiel
elpiel approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Testing setup can be improved in the future

@elpiel elpiel merged commit 8db0a60 into aip-61-adex-v5 Apr 13, 2022
@elpiel elpiel added this to the sentry-v0.2.0 milestone Apr 13, 2022
@elpiel elpiel linked an issue Apr 13, 2022 that may be closed by this pull request
AIP #61 v5: Channel and Campaign #382
Closed
21 tasks
@elpiel elpiel deleted the tests-for-collect-channels-campaign-list branch April 13, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP #61 v5: Channel and Campaign
2 participants
@simzzz @elpiel