Validator worker test coverage #469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpiel
requested changes
Mar 21, 2022
There was a problem hiding this comment.
I've forgot about this PR, sorry about that, next time you can ping me ;)
Instead of faking the accountings we have to work with real-life scenarios, the same way that the real system will work.
So create events for those campaigns and expect a certain message & balances at the end
test_harness/src/lib.rs
Outdated
| @@ -884,6 +900,396 @@ mod tests { | |||
| .send() | |||
| .await?) | |||
| } | |||
|
|
|||
| // Potential TODO's: Merge both test cases into one and find a way to retrieve heartbeats | |||
There was a problem hiding this comment.
You can retrieve the heartbeats using get_our_latest_msg after running a single tick.
|
see #486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO's:
Maybe moveCall function through run_full_test() insteadtest_leader_and_follower_tick()into a new file