Skip to content

Issue #382 Channel and Campaign Database & Persistance #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 25, 2021
Merged

Issue #382 Channel and Campaign Database & Persistance #400

merged 25 commits into from
May 25, 2021

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Apr 28, 2021 •
edited
Loading

Part of #382

Changelog:

@elpiel elpiel changed the title Issue 382 channel and campaign Issue #382 Channel and Campaign Apr 28, 2021
@elpiel elpiel changed the base branch from master to aip-61-adex-v5 April 28, 2021 13:15
elpiel and others added 15 commits April 28, 2021 16:21
@elpiel
primtivies - campaign impls of FromSql, ToSql & Row:
35fe2a2 
- prim - Campaign - From<Row>
- prim - campaing - Validators - From/ToSql
- prim - campaing - PricingBounds - From/ToSql
- prim - EventSubmission - From/ToSql
- prim - targeting - eval - Rules - FromSql
- prim - AdUnit - From/ToSql
@elpiel
sentry - db - campaign - insert_campaign
cd691a6
@elpiel
WIP sentry - routes - campaign create
1c6e49b
@simzzz
Added fetch campaign implementation + postgres integration tests
5c74e89
@simzzz
removed a field which was retrieved twice
d0eadc8
@simzzz
Imported active
cfffdac
@simzzz
removed try_from for from
05a39e1
@simzzz
comitting progress
71abe12
@simzzz
renamed function because of clippy
e6468bf
@simzzz
code clean up
13c2c25
@simzzz
fixed failing test
78695f6
@elpiel
sentry - db - fix issue with creating test DB pool twice
9be0bc5
@simzzz
requested changes from review
0495813
@simzzz
removed dbg
a5719e0
@elpiel
Merge pull request #401 from AdExNetwork/fetch_campaign_and_postgres_…
97fa17f 
…tests

Added fetch campaign implementation + postgres integration tests
@elpiel elpiel changed the title Issue #382 Channel and Campaign Issue #382 Channel and Campaign Database & Persistance May 20, 2021
@elpiel elpiel requested review from simzzz and samparsky May 20, 2021 10:27
@elpiel elpiel marked this pull request as ready for review May 20, 2021 10:28
@elpiel elpiel mentioned this pull request May 20, 2021
Closed
21 tasks
@elpiel elpiel merged commit 8e8c24c into aip-61-adex-v5 May 25, 2021
@elpiel elpiel deleted the issue-382-channel-and-campaign branch May 25, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samparsky samparsky samparsky approved these changes

@simzzz simzzz Awaiting requested review from simzzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elpiel @samparsky @simzzz