Adapter calculate and retrieve total spendable amount #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpiel
reviewed
Mar 17, 2021
5 tasks
|
After some discussion with Ivo, we came to the following changes: This could change in the future, as we will introduce the |
5 tasks
elpiel
reviewed
Mar 29, 2021
- adapter - ABI & bytecode files clean up
elpiel
force-pushed
the
issue-380-adapter-total-spendable-amount
branch
from
6c3f3ae to
f2b2fa2
Compare
TODO:
|
samparsky
reviewed
May 11, 2021
| @@ -20,11 +20,30 @@ ip_rate_limit = { type = 'ip', timeframe = 20000 } | |||
| sid_rate_limit = { type = 'sid', timeframe = 20000 } | |||
|
|
|||
| ethereum_core_address = '0x333420fc6a897356e69b62417cd17ff012177d2b' | |||
| # TODO: Replace with real contract address | |||
| outpace_address = '0x333420fc6a897356e69b62417cd17ff012177d2b' | |||
| # TODO: Replace with real contract address | |||
There was a problem hiding this comment.
to make tests reproducible we can create a ganache snapshot of the required deployments and use it on startup
There was a problem hiding this comment.
This is a cool idea for enhancement!
How can we do that?
samparsky
approved these changes
May 11, 2021
TODO: uncomment sweeper test case once we figure out what's wrong with the contract call
sweeper test case
elpiel
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
adapter.get_deposit(...)for the Ethereum and Dummy adapters, including an integration test.Change Log:
adapter::EthereumAdapter- Added aget_deposit()function which calculates and returns total spendable amount, using theOUTPACEandERC20ABI's.adapter::ethereum::Error- Added two new possible errors. The first beingTokenNotWhitelistedwhich is returned when the function is called with a channel with a deposit asset not being in the config's whitelist. The second isInvalidDepositAssetwhich is used when a channel's deposit asset cannot be converted toAddress. This error is here temporarily and I assume it will be gone soon when thechannel_v5replaces the oldchannelin the adapter.dev.toml and prod.toml configs- Changed the structure oftoken_addr_whitelistfrom an array of strings, to an array with objects that containaddress,min_token_units_for_depositandprecision.primitives::adapter::Deposit- new struct representing theget_deposit()output. Added signature forget_depositin theimplprimitives::channel_validator::asset_listed()- Changedasset_listed()function to work with the new token whitelist structure from String Vec to HashMap.primitives::config- Changed token whitelist from String Vec to HashMap. Added a new struct calledTokenInfowhich represents the value for the token whitelist HashMap.