-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cascading] from release/11.2 to release/11.3 #2653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Proposed change <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* <!-- * 🐛 Fix #issue --> <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- * Pull Request #issue -->
## Proposed change Emit an empty array of actions to execute when no ruleset remains active during the executions of rules engine. Nowadays there is no emission so the already applied actions are not reset. ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> *- No issue associated -* * 🐛 Fix #2609 <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- * Pull Request #issue -->
## Proposed change Add the support of the `null` as deepFill object field value <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. --> ## Related issues <!-- Please make sure to follow the [contribution guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md) --> <!-- * 🐛 Fix #issue --> * 🐛 Fix resolves #2601 <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- * Pull Request #issue -->
<!-- {"currentBranch":"release/10.4","targetBranch":"release/11.0","bypassReviewers":false,"isConflicting":false} --> ## Cascading from release/10.4 to release/11.0 --- :heavy_exclamation_mark: The pull request is conflicting with the target branch. You can fix the issue locally with the following commands: <details open> <summary>Using <b>gh CLI</b></summary> ```shell gh pr checkout 2614 git pull --ff origin release/11.0 ``` and update this Pull Request with ```shell gh pr push 2614 ``` </details> <details> <summary>Using <b>git</b> only</summary> ```shell git fetch origin git checkout origin/cascading/10.4.0-11.0.0 git pull --ff origin release/11.0 ``` and update this Pull Request with ```shell git push origin HEAD:cascading/10.4.0-11.0.0 ``` </details> --- <small>This Pull Request has been generated with :heart: by the [Otter](https://github.com/AmadeusITGroup/otter) cascading tool.</small>
<!-- {"currentBranch":"release/11.0","targetBranch":"release/11.1","bypassReviewers":false,"isConflicting":false} --> ## Cascading from release/11.0 to release/11.1 --- :heavy_exclamation_mark: The pull request is conflicting with the target branch. You can fix the issue locally with the following commands: <details open> <summary>Using <b>gh CLI</b></summary> ```shell gh pr checkout 2632 git pull --ff origin release/11.1 ``` and update this Pull Request with ```shell gh pr push 2632 ``` </details> <details> <summary>Using <b>git</b> only</summary> ```shell git fetch origin git checkout origin/cascading/11.0.0-11.1.0 git pull --ff origin release/11.1 ``` and update this Pull Request with ```shell git push origin HEAD:cascading/11.0.0-11.1.0 ``` </details> --- <small>This Pull Request has been generated with :heart: by the [Otter](https://github.com/AmadeusITGroup/otter) cascading tool.</small>
<!-- {"currentBranch":"release/11.1","targetBranch":"release/11.2","bypassReviewers":true,"isConflicting":false} --> ## Cascading from release/11.1 to release/11.2 The configuration requests the cascading to bypass reviewer in case of CI success. To not bypass the reviewing process, please check the following checkbox: - [ ] <!-- !cancel bypass! --> 🚫 stop reviewing process bypass for this Pull Request --- <small>This Pull Request has been generated with ❤️ by the [Otter](https://github.com/AmadeusITGroup/otter) cascading tool.</small>
matthieu-crouzet
approved these changes
Dec 30, 2024
View your CI Pipeline Execution ↗ for commit 4d1052c.
☁️ Nx Cloud last updated this comment at |
vscaiceanu-1a
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cascading from release/11.2 to release/11.3
❗ The pull request is conflicting with the target branch.
You can fix the issue locally with the following commands:
Using gh CLI
and update this Pull Request with
Using git only
and update this Pull Request with
This Pull Request has been generated with ❤️ by the Otter cascading tool.