Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set peer-dependencies to caret #2569

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: set peer-dependencies to caret #2569

merged 1 commit into from
Dec 11, 2024

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Dec 9, 2024

Proposed change

chore: set peer-dependencies to caret

Related issues

@kpanot kpanot requested a review from a team as a code owner December 9, 2024 08:00
@kpanot kpanot force-pushed the feature/peer-to-carret branch 2 times, most recently from 8397783 to 72e40a8 Compare December 9, 2024 10:40
fpaul-1A
fpaul-1A previously approved these changes Dec 9, 2024
"@angular-devkit/core": "~18.2.0",
"@angular-devkit/schematics": "~18.2.0",
"@angular/cli": "~18.2.0",
"@angular-devkit/architect": "^0.1802.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will accept 0.1900.0 which is potentially problematic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, only the first version non-null is locked with ^.
In that case of ^0.1802.0, it locks 0.1802

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

* Replace the caret ranges by tildes range
* @param range Range to replace
*/
export const enforceTildeRange = (range?: string) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid confusion, can this method have a different name from the flag enforceTildeRange ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take suggestion if you have some, otherwize I let it as it is :)

packages/@o3r/rules-engine/package.json Show resolved Hide resolved
@kpanot kpanot force-pushed the feature/peer-to-carret branch 4 times, most recently from a89907d to f83cd0e Compare December 10, 2024 06:57
@kpanot kpanot force-pushed the feature/peer-to-carret branch from f83cd0e to 17c1104 Compare December 10, 2024 08:34
@kpanot kpanot force-pushed the feature/peer-to-carret branch 2 times, most recently from ab55033 to 108ed33 Compare December 10, 2024 09:01
mrednic-1A
mrednic-1A previously approved these changes Dec 10, 2024
@kpanot kpanot force-pushed the feature/peer-to-carret branch from e7a6d7d to 8e0ba50 Compare December 10, 2024 16:19
@kpanot kpanot added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 06f004a Dec 11, 2024
36 checks passed
@kpanot kpanot deleted the feature/peer-to-carret branch December 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: More flexible peer deps version ranges
6 participants