-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set peer-dependencies to caret #2569
Conversation
8397783
to
72e40a8
Compare
72e40a8
to
60602bd
Compare
"@angular-devkit/core": "~18.2.0", | ||
"@angular-devkit/schematics": "~18.2.0", | ||
"@angular/cli": "~18.2.0", | ||
"@angular-devkit/architect": "^0.1802.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will accept 0.1900.0
which is potentially problematic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nop, only the first version non-null is locked with ^
.
In that case of ^0.1802.0
, it locks 0.1802
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting.
* Replace the caret ranges by tildes range | ||
* @param range Range to replace | ||
*/ | ||
export const enforceTildeRange = (range?: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid confusion, can this method have a different name from the flag enforceTildeRange
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take suggestion if you have some, otherwize I let it as it is :)
a89907d
to
f83cd0e
Compare
packages/@o3r/schematics/src/rule-factories/ng-add/dependencies.ts
Outdated
Show resolved
Hide resolved
packages/@o3r/schematics/src/rule-factories/ng-add/dependencies.ts
Outdated
Show resolved
Hide resolved
f83cd0e
to
17c1104
Compare
packages/@o3r/schematics/src/rule-factories/ng-add/dependencies.ts
Outdated
Show resolved
Hide resolved
ab55033
to
108ed33
Compare
108ed33
to
e7a6d7d
Compare
e7a6d7d
to
8e0ba50
Compare
Proposed change
chore: set peer-dependencies to caret
Related issues