Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devexp): highlight components by group #2540

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthieu-crouzet
Copy link
Contributor

@matthieu-crouzet matthieu-crouzet commented Dec 2, 2024

Related issues

🚀 Feature #2532

How to test

With postMessage (chrome extension part is not done yet)

  • Set up groups (same message for the following configurations elementMinWidth, elementMinHeight, throttleInterval and maxDepth)
window.postMessage({
  type: 'otter',
  to: 'app',
  content: {
    dataType: 'changeHighlightConfiguration',
    groupsInfo: {
      otter: {
        backgroundColor: '#f4dac6',
        color: 'black',
        regexp: '^o3r',
        displayName: 'o3r'
      },
      designFactory: {
        backgroundColor: '#000835',
        regexp: '^df',
        displayName: 'df'
      },
      ngBootstrap: {
        backgroundColor: '#0d6efd',
        regexp: '^ngb',
        displayName: 'ngb'
      }
    }
  }
});
  • Activate highlight
window.postMessage({
  type: 'otter',
  to: 'app',
  content: {
    dataType: 'toggleHighlight',
    isRunning: true
  }
});

Copy link

nx-cloud bot commented Dec 2, 2024

View your CI Pipeline Execution ↗ for commit 29dfdcc.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 10m 2s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 1m 54s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 35s View ↗
nx run-many --target=build ✅ Succeeded 3m 12s View ↗
nx affected --target=test --cacheDirectory=D:\a... ✅ Succeeded 31s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 15s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-03 08:09:09 UTC

@github-actions github-actions bot added enhancement New feature or request project:@o3r/showcase labels Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 16.85393% with 148 lines in your changes missing coverage. Please review.

Project coverage is 65.63%. Comparing base (f4e354c) to head (29dfdcc).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mponents/src/devkit/highlight/highlight.service.ts 5.43% 87 Missing ⚠️
...es/@o3r/components/src/devkit/highlight/helpers.ts 28.33% 43 Missing ⚠️
.../src/devkit/components-devtools.message.service.ts 5.26% 18 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthieu-crouzet matthieu-crouzet force-pushed the feat/highlight-components branch from 23305f5 to 29dfdcc Compare January 3, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant