fix(localization): path generated in the angular.json in case of monorepo #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,12 +100,12 @@ export function updateLocalization(options: { projectName?: string | null | unde | |||
| locales: [ | |||
| 'en-GB' | |||
| ], | |||
| assets: [`${mainAssetsFolder}/locales`], | |||
| outputPath: `${devResourcesFolder}/localizations` | |||
| assets: [`${projectBasePath}/${mainAssetsFolder}/locales`], | |||
There was a problem hiding this comment.
shouldn't we add a test somewhere to be sure we will not remove that fix at some point ? or understand if we should supports both cases
There was a problem hiding this comment.
We do not have e2e for an application outside of the mono-repo.
I can add a UT only.
Edit: The UT of it would require too many changes (due embedded functions). I open the issue #2381 to follow it.
matthieu-crouzet
approved these changes
Oct 31, 2024
mrednic-1A
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path generated in the angular.json in case of monorepo.
Proposed change
Related issues
- No issue associated -