-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry): add telemetry wrapper for cli #2210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieu-crouzet
commented
Oct 1, 2024
void (async () => { | ||
try { | ||
const { createCliWithMetrics } = await import('@o3r/telemetry'); | ||
return createCliWithMetrics('@o3r/workspace:set-version', cliFn, { logger, preParsedOptions: options }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example made once, I will wait for the approval to make the other ones in another PR
matthieu-crouzet
force-pushed
the
feat/cli-wrapper
branch
from
October 1, 2024 14:28
946fa77
to
a3bae97
Compare
github-actions
bot
added
enhancement
New feature or request
project:@o3r/telemetry
project:@o3r/workspace
project:audit-gh-action
project:cascading-gh-action
project:get-npm-tag-gh-action
project:new-version-gh-action
labels
Oct 1, 2024
fpaul-1A
reviewed
Oct 1, 2024
kpanot
reviewed
Oct 1, 2024
matthieu-crouzet
force-pushed
the
feat/cli-wrapper
branch
3 times, most recently
from
October 2, 2024 07:19
a8ac773
to
9d47150
Compare
1 task
kpanot
previously approved these changes
Oct 2, 2024
matthieu-crouzet
force-pushed
the
feat/cli-wrapper
branch
2 times, most recently
from
October 2, 2024 14:07
dc4d781
to
bc44479
Compare
matthieu-crouzet
force-pushed
the
feat/cli-wrapper
branch
from
October 2, 2024 14:17
bc44479
to
3e14e0e
Compare
fpaul-1A
approved these changes
Oct 2, 2024
kpanot
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add telemetry wrapper for cli
Related issues