fix "in" construction regexp #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slach
requested changes
Jan 20, 2025
pkg/eval_query.go
Outdated
| @@ -2098,6 +2103,24 @@ func betweenBraces(query string) string { | |||
| return subQuery | |||
| } | |||
|
|
|||
| func betweenBrackets(query string) string { | |||
There was a problem hiding this comment.
betweenSquareBraces more mental name we already have betweenBraces and isClosured
Pull Request Test Coverage Report for Build 12987995802Details
💛 - Coveralls |
Slach
approved these changes
Jan 21, 2025
Slach
requested changes
Jan 21, 2025
There was a problem hiding this comment.
look #709 (comment)
lets try to add unit tests which cover new code?
Signed-off-by: Eugene Klimov <[email protected]>
Signed-off-by: Eugene Klimov <[email protected]>
Issue 705 tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #705