V3 frontend improvements #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 18, 2023 13:52
Slach
requested changes
Nov 28, 2023
|
|
||
| useEffect(() => { | ||
| if (selectedDatabase) { | ||
| fetchData(`http://localhost:8123/?query=SHOW%20TABLES%20FROM%20${selectedDatabase}%20FORMAT%20JSON`, setTables); |
There was a problem hiding this comment.
Please remove hard-code localhost here
it shall be simple SQL query instead of url encoded values
There was a problem hiding this comment.
Same as below
|
|
||
| useEffect(() => { | ||
| if (!!selectedDatabase || !!selectedTable || !!selectedColumnTimestampType) { | ||
| fetchData( |
There was a problem hiding this comment.
i hope this is a temporary approach and not final solution
There was a problem hiding this comment.
Of course, for testing purposes only
Slach
added a commit
that referenced
this pull request
Nov 28, 2023
Slach
reviewed
Dec 11, 2023
|
@lunaticusgreen please fix CI unittest failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.