TriggerSequence Minigame: Check if trigger is between two lines #796 #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlmasB
reviewed
Feb 21, 2024
...ameplay/src/main/kotlin/com/almasb/fxgl/minigames/triggersequence/TriggerSequenceMiniGame.kt
Outdated
Show resolved
Hide resolved
| if (miniGame.press(key)) { | ||
| // Has the correct key been pressed, and is the current view between the two lines | ||
| if (miniGame.press(key) && | ||
| currentTrigger.translateX >= line1.startX && |
There was a problem hiding this comment.
We are potentially being too strict here from the gameplay perspective. What if the current view X is less than line1.x but the right side of the view is still between line1.x and line2.x? I think we should allow it to be accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #796
Changes:
@AlmasB please review and let me know if further changes are needed
@DaleHuntGB @artemijsem