Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/CopilotReview.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Copilot Review

on:
pull_request_target:
types: [opened, synchronize, labeled, unlabeled]
branches:
- main

permissions: {}

jobs:
copilot-code-review:
if: ${{ contains(github.event.pull_request.labels.*.name, 'copilot-code-review') }}
runs-on: ubuntu-latest
permissions:
pull-requests: write
contents: read
steps:
- name: Check Init Event
env:
action: ${{ toJSON(github.event.action) }}
label: ${{ toJSON(github.event.label) }}
run: |
echo start review module
- name: Copilot PR Review
uses: AllyW/[email protected]
with:
APIKEY: ${{ secrets.APIKEY }}
ENDPOINT: ${{ secrets.ENDPOINT }}
AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_EVENT: ${{ toJSON(github.event) }}
code_suggest: True
pr_summary: True
pr_reset: True
4 changes: 4 additions & 0 deletions src/monitor-control-service/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
Release History
===============
1.2.1
++++++
* Update help messages

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎
Nothing to return.

1.2.0
++++++
* Update api-version to `2023-03-11` for sub cmds of `az monitor data-collection rule`
Expand Down
4 changes: 2 additions & 2 deletions src/monitor-control-service/azext_amcs/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ def load_arguments(self, _): # pylint: disable=unused-argument
c.argument('resource_uri', options_list=['--resource', '--resource-uri'],
help='The identifier of the resource.')
c.argument('association_name', options_list=['--name', '-n'], help='The name of the association.')
c.argument('description', help='Description of the association.')
c.argument('description', help='Description of the association.For more message, please check: https:learn.microsoft.com/en-us/cli/azure/monitor/data-collection/endpoint/association?view=azure-cli-latest#az-monitor-data-collection-endpoint-association-list')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎

  • The URL is incomplete. It should be https://learn.microsoft.com/en-us/cli/azure/monitor/data-collection/endpoint/association?view=azure-cli-latest#az-monitor-data-collection-endpoint-association-list.

  • The placeholder <resource/monitor/endpoint_id> should be enclosed in backticks for clarity and compliance with markdown formatting.

c.argument('rule_id', help='The resource ID of the data collection rule that is to be associated.')
c.argument('endpoint_id', help='The resource ID of the data collection endpoint that is to be associated.',
c.argument('endpoint_id', help='The resource ID of the data collection endpoint that is to be associated. Format like <resource/monitor/endpoint_id>',
validator=validate_association_name_with_endpoint)
c.argument('data_collection_rule_name', options_list=['--rule-name', '--data-collection-rule-name'])

Expand Down
2 changes: 1 addition & 1 deletion src/monitor-control-service/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from setuptools import setup, find_packages

# HISTORY.rst entry.
VERSION = '1.2.0'
VERSION = '1.2.1'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down