-
Notifications
You must be signed in to change notification settings - Fork 0
test fixruncmd #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
||
| 3.0.0 | ||
| ++++++ | ||
| * Add new param --new to override the existing database user and deprecate Postgres single server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the release notes:
- Improve version format consistency.
- Provide a brief but clear description of the improvements and fixes.
Refinement:
3.0.1
++++++
* Improvements and security fixes.
| 'az ad sp show --id "{}"'.format(d['client_id'])) | ||
| if output: | ||
| d['principal_id'] = output.get('id') | ||
| else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use f-strings for better readability and performance:
Replace'az ad sp show --id "{}"'.format(d['client_id'])withf'az ad sp show --id "{d["client_id"]}"'.
Refined Code:
output = run_cli_cmd(f'az ad sp show --id "{d["client_id"]}"')|
|
||
| VERSION = '3.0.0' | ||
| VERSION = '3.0.1' | ||
| NAME = 'serviceconnector-passwordless' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Version Update:
- Ensure that the change in
VERSIONfrom '3.0.0' to '3.0.1' is reflected in all associated documentation and changelogs.
- Ensure that the change in
-
Consistency:
- Verify that the updated
VERSIONandNAMEare consistent throughout the entire codebase.
- Verify that the updated
Other than ensuring version consistency and documentation update, the diff appears simple and accurate.
| VERSION = '3.0.1' | ||
| try: | ||
| from azext_serviceconnector_passwordless.config import VERSION | ||
| except ImportError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The logger warning could be made more informative with specifics about the issue.
- Update the version to reflect significant changes if applicable.
Refinements:
logger.warn("Wheel is not available; the 'bdist_wheel' hook has been disabled.")- Confirm if changing
VERSIONto '3.0.1' is necessary for the minor update or if it reflects a significant change.
| @@ -1,7 +1,11 @@ | |||
| .. :changelog: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary:
- Updated version to 3.0.1 with improvements and security fixes.
- Changed import from
msrestazure.toolstoazure.mgmt.core.tools. - Added or modified quotes around placeholders for
azcommands for consistency and correctness. - Ensured dynamic values are quoted in Azure CLI commands throughout the codebase for improved robustness.
- Improved error and warning messages for better clarity and guidance.
- Included additional telemetry information and enhanced validation logic.
7059eb5 to
3ab770e
Compare
* add pester tests for k8s-extension * Adding CLI Configuration for DisableInformerCache Flag (#2) This is required for our helm charts where customers can opt to change the caching behaviour during restore. * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * remove test cases specific to fork repo --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Mayank Aggarwal <[email protected]> Co-authored-by: bragi92 <[email protected]>
* add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * update readme and version release notes (#12) * remove extension specific pester tests --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bragi92 <[email protected]> Co-authored-by: Long Wan <[email protected]>
* add pester tests for k8s-extension * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Extend ContainerInsights Extension for high log scale mode support (#9) * update python version to 3.13 (#10) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * Add k8s-extension troubleshoot phase 1: Infrastructure setup. (#11) * [k8s-extension] Update extension CLI to v1.7.0 (#13) * remove redundant test files --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bragi92 <[email protected]> Co-authored-by: Long Wan <[email protected]> Co-authored-by: Andres Borja <[email protected]>
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <[email protected]> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <[email protected]> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]> * remove redundant test files --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: Vineeth Thumma <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]>
* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <[email protected]> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <[email protected]> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]> * remove hardcoded public ARM endpoint url for fairfax and mooncake (#24) * Bug Fix for FFX mcr url (#22) * [connectedk8s] update release notes and version (#26) * remove redundant test files * remove change not relevant to connectedk8s release --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Atchut Kumar Barli <[email protected]> Co-authored-by: Vineeth Thumma <[email protected]> Co-authored-by: mcnealm13 <[email protected]> Co-authored-by: Matthew McNeal (from Dev Box) <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: bgriddaluru <[email protected]> Co-authored-by: vithumma <[email protected]> Co-authored-by: hapate <[email protected]>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.