test pr code #2
Open
test pr code #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| Guidance | ||
| ++++++++ | ||
| If there is no rush to release a new version, please just add a description of the modification under the *Pending* section. |
There was a problem hiding this comment.
PR Summary:
- Updated the VM SKU regex to include a larger set of VMs eligible for Azure Container Storage.
- Increased the version number from 7.0.0b7 to 7.0.0b8 in
setup.pyand added a new version section in the changelog.
| pattern = r'standard_([a-z]+)(\d+)([a-z]*)(?:_[^_]+)*_v(\d+)' | ||
| match = re.search(pattern, vm_size.lower()) | ||
| if match: | ||
| series_prefix = match.group(1) |
There was a problem hiding this comment.
- The updated regex pattern is more complex; clarify it with a comment explaining the logic.
- Instead of
re.search, usere.matchsince the pattern is expected to match from the start.
Refinement:
# Updated pattern to handle optional segments between the size and version
pattern = r'standard_([a-z]+)(\d+)([a-z]*)(?:_[^_]+)*_v(\d+)'
match = re.match(pattern, vm_size.lower())
| VERSION = "7.0.0b8" | ||
|
|
||
| CLASSIFIERS = [ | ||
| "Development Status :: 4 - Beta", |
There was a problem hiding this comment.
The version update from "7.0.0b7" to "7.0.0b8" is appropriate for indicating the new beta release. However, this diff does not show any other changes that require refining. Ensure all functional and necessary updates are included in separate commits for clarity.
AllyW
force-pushed
the
main
branch
2 times, most recently
from
7e9bcf3 to
087db12
Compare
AllyW
force-pushed
the
main
branch
3 times, most recently
from
7059eb5 to
3ab770e
Compare
AllyW
pushed a commit
that referenced
this pull request
Jun 3, 2025
* add pester tests for k8s-extension * Adding CLI Configuration for DisableInformerCache Flag (#2) This is required for our helm charts where customers can opt to change the caching behaviour during restore. * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * remove test cases specific to fork repo --------- Co-authored-by: Bavneet Singh <[email protected]> Co-authored-by: Mayank Aggarwal <[email protected]> Co-authored-by: bragi92 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.