This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Add JSON logger support #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR addresses issue #120 by adding JSON logging support to openhands-aci. |
Contributor
Author
|
I have fixed the linting issues:
All pre-commit hooks now pass successfully. |
raymyers
approved these changes
Jul 25, 2025
raymyers
suggested changes
Jul 25, 2025
Contributor
raymyers
left a comment
raymyers
left a comment
There was a problem hiding this comment.
Heya sorry we didn't see this, thanks for putting it in. I think we might be able to handle this better by making the logger on OpenHands side add its handler, I'm going to try that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for JSON logging when LOG_JSON environment variable is set to true.
Related Issue
Fixes #120
Motivation and Context
In OpenHands, setting LOG_JSON=true enables JSON logging output. However, the openhands-aci logs do not support this format.
How Has This Been Tested?
Added unit tests for the JSON formatter and manually tested with LOG_JSON=true/false.
Does this PR introduce a breaking change?
No.