Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Keeping runtimes alive again (For now) #6395

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Jan 21, 2025

Runtimes will not be actively culled again (For now)

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

We will need to do a follow up fix here before we expose the multi conversation UI to everybody outside the feature flag.

The follow up fix will need to allow pausing / restarting of docker runtimes in a similar manner to the remote runtime.


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:da50d57-nikolaik   --name openhands-app-da50d57   docker.all-hands.dev/all-hands-ai/openhands:da50d57

@tofarr tofarr marked this pull request as ready for review January 21, 2025 18:43
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 21, 2025

Should fix: #6382

@tofarr tofarr enabled auto-merge (squash) January 21, 2025 19:05
@tofarr tofarr merged commit 09e8a1e into main Jan 21, 2025
14 checks passed
@tofarr tofarr deleted the fix-keep-runtimes-alive branch January 21, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants