feat(frontend): Add active status for ws #5944
Merged
+16
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
requested changes
Dec 31, 2024
|
@amanape we should check AgentStatus rather than adding agent state into the websocket state |
rbren
reviewed
Jan 2, 2025
| @@ -71,7 +71,7 @@ export const useWSStatusChange = () => { | |||
| } | |||
| statusRef.current = status; | |||
|
|
|||
| if (status === WsClientProviderStatus.CONNECTED && initialQuery) { | |||
| if (status !== WsClientProviderStatus.DISCONNECTED && initialQuery) { | |||
There was a problem hiding this comment.
any particular reason for these flips? Or just a remnant of the original implementation?
There was a problem hiding this comment.
They are remnants of the original implementation, but are also helpful in the (unlikely) case we extend the WsClientProviderStatus enum
There was a problem hiding this comment.
LMK if you think we should change it, should be a minute-PR
rbren
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Endpoints such as
/list-filesshould only call once runtime is activeWe have two status'
CONNECTEDandDISCONNECTED. WS is set toCONNECTEDif a ws connection is established, not when runtime is activeInclude this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
Give a summary of what the PR does, explaining any non-trivial design decisions
ACTIVEstatusLink of any specific issues this addresses
To run this PR locally, use the following command: