-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): enhance GitHub repo picker with search and sorting #5783
Conversation
- Add GitHub API search for public repos when user enters a query - Show stargazer count for searched repos - Keep repos sorted by pushed_at (most recent first) - Place searched repo at the top of the picker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and the behavior of the search functionality is somewhat unintuitive. For instance, I did:
Lightning-AI/lit
and it gave me a result of Lightning-AI/lit-llama
(which has about 6000 stars) and then I continued typing Lightning-AI/litgpt
and got Lightning-AI/litgpt
(which has 10,000 stars). It seems that maybe it should display more than one result when it searces public repos, and it should sort in descending order of stars, given that stars are displayed in the interface.
OVERVIEW:
STATUS: ✅ FULLY RESOLVED |
frontend/src/components/features/github/github-repo-selector.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/features/github/github-repo-selector.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: sp.wack <[email protected]>
Overview:
No remaining issues identified - the implementation appears to completely address the reported problem. |
@openhands-agent Frontend linting is failing. Please find pre-commit-config.yml and install pre-commit, and run it on all of the files modified in this PR to fix linting errors. |
OVERVIEW: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to model-selector.tsx
seem unrelated to the intended content of the PR. Please revert them back to be the same as the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to model-selector.test.tsx
seem unrelated to the intended content of the PR. Please revert them back to be the same as the main branch.
@openhands-agent the changes to |
OVERVIEW:
No remaining issues to address. |
I tested this and it now works as expected, turning this over to @amanape for a final review! |
frontend/__tests__/components/context-menu/account-settings-context-menu.test.tsx
Outdated
Show resolved
Hide resolved
frontend/__tests__/components/features/github/github-repo-selector.test.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/features/github/github-repo-selector.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/features/github/github-repo-selector.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/features/github/github-repo-selector.tsx
Outdated
Show resolved
Hide resolved
Tests are the things that look the most off, the rest is starting to look real good |
Co-authored-by: sp.wack <[email protected]>
Co-authored-by: sp.wack <[email protected]>
This PR enhances the GitHub repository picker with the following features:
To run this PR locally, use the following command: