[pull] master from web-platform-tests:master#2253
Merged
Merged
Conversation
For subgrids whose final position isn't known at sizing time (e.g. inside a grid-lanes ancestor that places after sizing), the accumulated edge extra margins propagated to a nested subgrid must account for the largest contribution the subgrid could pick up at any candidate position. Previously we only forwarded the parent's accumulated edge margins, which under-reserved space when a parent gap could land immediately outside the subgrid's boundary. Update `CreateSubgridTrackCollection` so that when the subgrid is auto-placed in its parent, the start/end accumulated extra margins are computed as follows: - If the subgrid spans every track of the parent, no parent gap can ever be adjacent to the subgrid's boundary; forward the parent's accumulated edge margins as-is. - If the parent has exactly one more track than the subgrid, the subgrid can only ever have a parent gap on one side. Reserve the half-gutter contribution on whichever side currently carries the smaller accumulated edge margin so we don't double-count. - Otherwise, take max(accumulated edge margin, parent gutter delta / 2) on both sides, since any combination of start/end positions is possible. Add a bit more test coverage, although a follow up change will be needed to get the true largest final accumulation numbers, which will be handled in a follow up change and will likely lead to some changes to existing test expectations in some cases. Bug: 343257585 Change-Id: I0742fef87af1008ba43a07f557f31281c24344c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7897846 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1644722}
This WPT was failing on Windows because of forced rounding from DWrite. Though certainly not ideal, that is not the space this test is attempting to cover, so this change updates the test to ensure the initial underline position expected from the font is a whole number, so that the test is only testing the text-underline-offset impact, and not the platform-specific font-reading code. For more details: The expected values for close_underline (UNDO=200) and far_underline (UNDO=1000) are 2.15625 and 9.375 respectively (if my math is correct), which when rounded to final pixels become 2 and 9. The starting underline position for the font (default UNDO=500) comes to 4.6875px, but DWrite returns this underlinePosition as an INT16, which in this case is rounded to 5. This means that on Windows, after applying the text-underline-offsets of -2.5px and 4.6px, the positions became 2.5px and 9.6px, which when rounded to final pixels became 3 and 10 (instead of the expected 2 and 9). Other platforms do not encounter this problem because they either return the underline position from the font in a float, or in more granular units. This change overrides the default UNDO=500 with UNDO=640, which comes to exactly 6px. Fix: 1140324 Change-Id: I5845eb8d258f0879427b9f203e063937afb9a035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7913911 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1644739}
ServiceWorkerHost is responsible for brokering WebSocket and WebTransport connections within the worker. For proper integration with Connection Allowlist, the host now provides the ServiceWorkerVersion's network_restrictions_id when creating those connections. Note that once this CL is merged, WebSocket and WebTransport should have full coverage across documents, dedicated, shared, and service workers. Bug: 492462310 Fixed: 492462310 Change-Id: If9700eef886901e5ad20ea02981637f0c5c1c016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7902842 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Andrew Verge <averge@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/main@{#1644755}
This change allows an accelerated video frame to be painted into a display list which is passed to another thread, and then rasterized from the other thread. The downside is that the PaintCanvasVideoRenderer cache is effectively disabled, so if a single video frame is painted multiple times it will be forced to use multiple GPU shared images. This seems like an unlikely circumstance and fixing it would be complicated, so this CL punts. Bug: 435230899 Change-Id: Ic51cac7aba434412293e0b72437dc0bf4a5edd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7900160 Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1644771}
This CL modifies blink::AnimationTrigger's play-forwards and play-backwards behaviors so that they do not auto-rewind if the animation is already finished in the target direction. CSSWG resolution: w3c/csswg-drafts#13643 (comment) We are getting this PSA ready to accompany this change: https://chromestatus.com/feature/5071640598806528 Bug: 390314945 Change-Id: Id9bcb06c8e0833141c5a61feb8dbec5a0397bfd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7902733 Commit-Queue: David A <awogbemila@chromium.org> Reviewed-by: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/main@{#1644772}
Bug: 521861823 Change-Id: Idd76c57c027c2f7e2585c1525ab14932deea2c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7919507 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: David A <awogbemila@chromium.org> Cr-Commit-Position: refs/heads/main@{#1644815}
This is a reland of commit 6c3c7a1a61db01bcf82d2658a30b3632619c3b92 This reland updates the WPT expected results on Mac, as the mac15-x64-rel-tests bot caught some failures in the newly added tests. Original change's description: > WebNN: Fix Pool2d ceil_mode to check both spatial dimensions > > The previous code only compared the height dimension's floor output > size against the WebNN output height to determine ceil_mode. When > only the width dimension required ceiling rounding (e.g., input > [1,1,5,5], window [3,2], strides [2,2], roundingType:"ceil"), the > height check passed with floor, so ceil_mode=0 was emitted. > > This caused a shape mismatch between Chromium's WebNN operand > descriptors (e.g., [1,1,2,3]) and ORT's actual execution shape > (e.g., [1,1,2,2]). The mismatch invalidated gather/scatter index > sanitization: indices valid for the WebNN shape could be out of > bounds for ORT's smaller tensor, enabling OOB read/write on > execution providers that do not validate indices at dispatch time. > > Fix: compute CalculateConv2dOutputSize for both height and width, > and set ceil_mode=1 when either dimension needs ceiling rounding. > ONNX Pool's ceil_mode is a single global attribute, so setting it > when any dimension requires ceiling is both correct and safe (ceiling > of an integer is itself). > > This CL also added some conformance tests for this scenario. > > Bug: 519241091 > Change-Id: I9dc92f5f81687286eaf6aca8468032fe152360d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7901552 > Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Xu, Mingming1 <mingming1.xu@intel.com> > Cr-Commit-Position: refs/heads/main@{#1643553} Bug: 519241091,521419439 Change-Id: I4ec18fc7d0fb91d64a292178e2630c437d0bb76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7909424 Commit-Queue: Hu, Ningxin <ningxin.hu@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Hu, Ningxin <ningxin.hu@intel.com> Cr-Commit-Position: refs/heads/main@{#1644829}
If the <reference-box> for overflow-clip-margin was content-box we didn't invalidate our clip if the padding changed. Mark the LayoutBox as needing a paint-property update for this case. Change-Id: I009e2ca39161e2d6aba8cb2390b78444376aa559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7914267 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1644874}
This UA style rule was preventing overflow:hidden from doing anything when set from author styles. Fixed: 521434907 Change-Id: I2d41b122b76a82c02efda61bfdb9fdc524f91951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7919309 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1644873}
This gives us better coverage. Differential Revision: https://phabricator.services.mozilla.com/D304961 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2045230 gecko-commit: 4bca04155b988c0d98e01f10429567e89bb7db96 gecko-commit-git: 0c8c2d7a8ddb354e0c37f7024e77691d54ede11a gecko-reviewers: gfx-reviewers, lsalzman
This reduces the effect and frequency of #51981, where we frequently saw timeouts from the H2 server, because we no longer repeatedly create new threads and new queues when we receive further events after StreamEnded, or an event with a reference to a StreamEnded. See the state diagram in https://httpwg.org/specs/rfc9113.html#StreamStates, noting that receiving StreamEnded only closes the connection when the stream is in the half-closed (local) state. This also means we treat a stream as closed when we send/receive a RST_STREAM frame.
Before this commit, resources/web-extensions-helper.js ("helper")
registered event listeners for onTestStarted and onTestFinished *after*
the promise for test extension installation resolved. Depending on the
browser, this could be a problem because the extension installation and
test execution could race with the installation promise.
In Chromium/Chrome specifically, this race is possible because the
extension installation process and test execution is not synchronous
and is not coordinated with the resolution of the test extension
installation promise. Therefore, there's a chance that an extension
could install, begin executing it's tests, and then the test extension
installation promise would resolve. The helper script context would
register it's onTestStarted and onTestFinished listeners, but by this
point the helper would've missed some test events.
After this commit, the helper's onTestStarted and onTestFinished event
listeners are registered synchronously prior to requesting extension
installation. The helper should now reliably capture onTestStarted and
onTestFinished when they are fired.
The commit additionally removes the listeners after all tests have
finished or if the test extension fails to install. This avoids leaking
listener registrations that will no longer be used (in case a browser
retains a record of these across WPT tests and doesn't automatically
delete them).
Bug: 493946949
Change-Id: I6f2c8eb178357946701c8bd88bf57ea5bcd79801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7904503
Reviewed-by: Tim <tjudkins@chromium.org>
Commit-Queue: Justin Lulejian <jlulejian@chromium.org>
Auto-Submit: Justin Lulejian <jlulejian@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1644871}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )