[pull] master from web-platform-tests:master#2171
Merged
Merged
Conversation
We'd end up in an infinite layout recursion, because column fragments were mistakenly believed to have `break-inside:avoid` (since this was specified on the multicol container), which makes no sense. The (anonymous) column fragments share ComputedStyle with the parent multicol container fragment (they have no LayoutBox on their own), but no style applies to the columns themselves. Bug: 512514755 Change-Id: I260c330a9dbfac47c4322d005d782368fbd67ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7844752 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1629836}
…metrics-003.html to also use ::selection. The test uses ::selection, which creates the accessible caret on CI. This patch changes the reference file to also use ::selection, so that the test and expectation match. Differential Revision: https://phabricator.services.mozilla.com/D285947 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2020930 gecko-commit: 169f8af6213ea060a3c4231da5ab49965452b3ef gecko-commit-git: bc4d43bca5ea08df5467917feda6afc988540665 gecko-reviewers: emilio
Differential Revision: https://phabricator.services.mozilla.com/D299654 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2038436 gecko-commit: 140509849b640df7322c229c3a8c63db3b9538ab gecko-commit-git: 80bd7c901af4cdc9b8b963a18eda145f8ee86eed gecko-reviewers: Sasha
Replace function-serialization injection with an inline sandbox check. Aligns the pattern with sandbox-document-open.html. Also fix typos in the comment.
In particular for sendBeacon() and the Media Session API. (Inspired by a test from Kagami for the Notifications API where we also fix the spelling per feedback from Kagami.)
It's not used and incorrect. Fixes #24280.
Co-authored-by: wpt-pr-bot <wpt-pr-bot@users.noreply.github.com>
Mirror the clip-path/offset-path pattern: store the <shape-box> on the non-interpolable value and gate compatibility on ShapeOutsideBoxesMatch. This lifts shape-outside out of the discrete fallback whenever both endpoints carry the same <shape-box>, including the rect()/xywh() syntax that canonicalizes to inset(). Bug: 490343453 Change-Id: Iaa7b821fa1f2f7cbad65c992c1e114a7f9aaac8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7842232 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Jason Leo <cgqaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1630109}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )