[pull] master from web-platform-tests:master#2169
Merged
Merged
Conversation
Co-authored-by: wpt-pr-bot <wpt-pr-bot@users.noreply.github.com>
There should be minimal behaviour differences between display:flex and display:-webkit-box. Previously we didn't blockify our children for -webkit-box. This meant that we could have "inline-level" anonymous tables sitting within the tree. This patch blockifies all children similar to flex. Adds a WPT compat test for this. This doesn't affect -webkit-line-clamp boxes as their computed value for display is coerced to "flow-root" This allows us to make LayoutBlock::AddChildBeforeDescendant have the exact same structure as LayoutTable, LayoutTableSection, LayoutTableRow AddChildBeforeDescendant. (new_child->IsInline() may be able to be converted to new_child->IsText() at a later stage). Change-Id: I2e2a141f9477602a60b463998080e10a196dcde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7836695 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1629284}
This CL adds a ServiceWorkerMainResourceLoaderInterceptor in the DownloadManagerImpl codepath that deals with Download requests created by Browser UI mechanisms, like the "Save As" contextual menu actions, as specified in the "Downloading resources" section [1] of the HTML spec. This is coherent with what we do in the NavigationURLLoader codepath, used when the download resource request is initiated as a result of a "download request 'navigate' event" [2], where a SW interceptor is added in the NavigationURLLoader::CreateInterceptors. The SW interceptor is added after the preliminary checks have been completed and just before the a Download request is processed, so that the Service Worker pipeline can create is own Fetch request. This ensure that the SW can handle 'fetch' events as it's doing when the Download is triggered by user "activation" events, which is handle by the Navigation codepath. [1]https://html.spec.whatwg.org/multipage/links.html#downloading-resources [2]https://html.spec.whatwg.org/multipage/nav-history-apis.html#fire-a-download-request-navigate-event Bug: 40410035 Change-Id: I354f5c3294b82a718eaff2c3fbfc17258201bf7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7782160 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/main@{#1629366}
Rename HTMLElement.prototype.focusgroup to focusGroup, matching tabIndex, accessKey, inputMode, and other multi-word reflected attributes. Also add focusGroupStart for the existing focusgroupstart content attribute, which had no IDL reflection. The content attribute names (focusgroup, focusgroupstart) are unchanged in this CL. Bug: 4021071 Change-Id: I6015bc1d83daa409b2e98018759d568d73c10d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7823287 Auto-Submit: Jacques Newman <janewman@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1629413}
This implements the CSSWG resolution modifying the interactions between scrollIntoView and scroll-snap-align. Bug: 40942148 Change-Id: I7ea4d49f504cd6cb7f6df662f6f3a9e5444dd976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7824200 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: David A <awogbemila@chromium.org> Cr-Commit-Position: refs/heads/main@{#1629410}
Link to explainer and spec modification: WICG/manifest-incubations#119 Bug: 465492409 Test: testing/xvfb.py tools/autotest.py -C out_/Default chrome/browser/ui/views/web_apps/frame_toolbar/web_app_frame_toolbar_browsertest.cc Change-Id: Ie9d37b64460055314c47d8d394b7ae9015b2cee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7822362 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Edman Anjos <edman@chromium.org> Reviewed-by: Mike Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/main@{#1629445}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )