Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ require (
golang.org/x/sys v0.44.0
golang.org/x/term v0.43.0
golang.org/x/text v0.37.0
google.golang.org/grpc v1.81.0
google.golang.org/grpc v1.81.1
google.golang.org/protobuf v1.36.11
gopkg.in/h2non/gock.v1 v1.1.2
gopkg.in/yaml.v3 v3.0.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,8 @@ google.golang.org/genproto/googleapis/api v0.0.0-20260316180232-0b37fe3546d5 h1:
google.golang.org/genproto/googleapis/api v0.0.0-20260316180232-0b37fe3546d5/go.mod h1:EIQZ5bFCfRQDV4MhRle7+OgjNtZ6P1PiZBgAKuxXu/Y=
google.golang.org/genproto/googleapis/rpc v0.0.0-20260316180232-0b37fe3546d5 h1:aJmi6DVGGIStN9Mobk/tZOOQUBbj0BPjZjjnOdoZKts=
google.golang.org/genproto/googleapis/rpc v0.0.0-20260316180232-0b37fe3546d5/go.mod h1:4Hqkh8ycfw05ld/3BWL7rJOSfebL2Q+DVDeRgYgxUU8=
google.golang.org/grpc v1.81.0 h1:W3G9N3KQf3BU+YuCtGKJk0CmxQNbAISICD/9AORxLIw=
google.golang.org/grpc v1.81.0/go.mod h1:xGH9GfzOyMTGIOXBJmXt+BX/V0kcdQbdcuwQ/zNw42I=
google.golang.org/grpc v1.81.1 h1:VnnIIZ88UzOOKLukQi+ImGz8O1Wdp8nAGGnvOfEIWQQ=
google.golang.org/grpc v1.81.1/go.mod h1:xGH9GfzOyMTGIOXBJmXt+BX/V0kcdQbdcuwQ/zNw42I=
google.golang.org/protobuf v1.36.11 h1:fV6ZwhNocDyBLK0dj+fg8ektcVegBBuEolpbTQyBNVE=
google.golang.org/protobuf v1.36.11/go.mod h1:HTf+CrKn2C3g5S8VImy6tdcUvCska2kB7j23XfzDpco=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
Expand Down
13 changes: 13 additions & 0 deletions pkg/cmd/release/shared/fetch.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,19 @@ func FetchRefSHA(ctx context.Context, httpClient *http.Client, repo ghrepo.Inter
return ref.Object.SHA, nil
}

// DigestAlgForRef returns the digest algorithm name corresponding to the given
// git ref SHA. SHA-1 git object IDs are 40 hex characters and SHA-256 git
// object IDs are 64 hex characters. Unknown lengths default to "sha1" to
// preserve backwards-compatible behavior.
func DigestAlgForRef(digest string) string {
switch len(digest) {
case 64:
return "sha256"
default:
return "sha1"
}
}

// FetchRelease finds a published repository release by its tagName, or a draft release by its pending tag name.
func FetchRelease(ctx context.Context, httpClient *http.Client, repo ghrepo.Interface, tagName string) (*Release, error) {
cc, cancel := context.WithCancel(ctx)
Expand Down
35 changes: 35 additions & 0 deletions pkg/cmd/release/shared/fetch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,38 @@ func TestFetchRefSHA(t *testing.T) {
})
}
}

func TestDigestAlgForRef(t *testing.T) {
tests := []struct {
name string
digest string
expected string
}{
{
name: "sha1 (40 hex chars)",
digest: "1234567890abcdef1234567890abcdef12345678",
expected: "sha1",
},
{
name: "sha256 (64 hex chars)",
digest: "1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef",
expected: "sha256",
},
{
name: "empty string defaults to sha1",
digest: "",
expected: "sha1",
},
{
name: "unexpected length defaults to sha1",
digest: "abc",
expected: "sha1",
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
assert.Equal(t, tt.expected, DigestAlgForRef(tt.digest))
})
}
}
2 changes: 1 addition & 1 deletion pkg/cmd/release/verify-asset/verify_asset.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ func verifyAssetRun(config *VerifyAssetConfig) error {
return err
}

releaseRefDigest := artifact.NewDigestedArtifactForRelease(ref, "sha1")
releaseRefDigest := artifact.NewDigestedArtifactForRelease(ref, shared.DigestAlgForRef(ref))

// Find attestations for the release tag SHA
attestations, err := config.AttClient.GetByDigest(api.FetchParams{
Expand Down
55 changes: 53 additions & 2 deletions pkg/cmd/release/verify-asset/verify_asset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func Test_verifyAssetRun_SuccessNoTagArg(t *testing.T) {
require.NoError(t, err)
}

func Test_verifyAssetRun_FailedNoAttestations(t *testing.T) {
func Test_verifyAssetRun_FailedNoAttestations_SHA1(t *testing.T) {
ios, _, _, _ := iostreams.Test()
tagName := "v1"

Expand All @@ -180,6 +180,55 @@ func Test_verifyAssetRun_FailedNoAttestations(t *testing.T) {

releaseAssetPath := test.NormalizeRelativePath("../../attestation/test/data/github_release_artifact.zip")

var capturedParams api.FetchParams
attClient := &api.MockClient{
OnGetByDigest: func(params api.FetchParams) ([]*api.Attestation, error) {
capturedParams = params
return api.OnGetByDigestFailure(params)
},
}

cfg := &VerifyAssetConfig{
Opts: &VerifyAssetOptions{
AssetFilePath: releaseAssetPath,
TagName: tagName,
BaseRepo: baseRepo,
Exporter: nil,
},
IO: ios,
HttpClient: &http.Client{Transport: fakeHTTP},
AttClient: attClient,
AttVerifier: nil,
}

err = verifyAssetRun(cfg)
require.ErrorContains(t, err, "no attestations found for tag v1")
require.ErrorContains(t, err, "sha1:"+fakeSHA)
require.Equal(t, "sha1:"+fakeSHA, capturedParams.Digest)
}

func Test_verifyAssetRun_FailedNoAttestations_SHA256(t *testing.T) {
ios, _, _, _ := iostreams.Test()
tagName := "v1"

fakeHTTP := &httpmock.Registry{}
defer fakeHTTP.Verify(t)
fakeSHA := "1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef"
shared.StubFetchRefSHA(t, fakeHTTP, "owner", "repo", tagName, fakeSHA)

baseRepo, err := ghrepo.FromFullName("owner/repo")
require.NoError(t, err)

releaseAssetPath := test.NormalizeRelativePath("../../attestation/test/data/github_release_artifact.zip")

var capturedParams api.FetchParams
attClient := &api.MockClient{
OnGetByDigest: func(params api.FetchParams) ([]*api.Attestation, error) {
capturedParams = params
return api.OnGetByDigestFailure(params)
},
}

cfg := &VerifyAssetConfig{
Opts: &VerifyAssetOptions{
AssetFilePath: releaseAssetPath,
Expand All @@ -189,12 +238,14 @@ func Test_verifyAssetRun_FailedNoAttestations(t *testing.T) {
},
IO: ios,
HttpClient: &http.Client{Transport: fakeHTTP},
AttClient: api.NewFailTestClient(),
AttClient: attClient,
AttVerifier: nil,
}

err = verifyAssetRun(cfg)
require.ErrorContains(t, err, "no attestations found for tag v1")
require.ErrorContains(t, err, "sha256:"+fakeSHA)
require.Equal(t, "sha256:"+fakeSHA, capturedParams.Digest)
}

func Test_verifyAssetRun_FailedTagNotInAttestation(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/release/verify/verify.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func verifyRun(config *VerifyConfig) error {
return err
}

releaseRefDigest := artifact.NewDigestedArtifactForRelease(ref, "sha1")
releaseRefDigest := artifact.NewDigestedArtifactForRelease(ref, shared.DigestAlgForRef(ref))

// Find all the attestations for the release tag SHA
attestations, err := config.AttClient.GetByDigest(api.FetchParams{
Expand Down
52 changes: 50 additions & 2 deletions pkg/cmd/release/verify/verify_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func Test_verifyRun_Success(t *testing.T) {
require.NoError(t, err)
}

func Test_verifyRun_FailedNoAttestations(t *testing.T) {
func Test_verifyRun_FailedNoAttestations_SHA1(t *testing.T) {
ios, _, _, _ := iostreams.Test()
tagName := "v1"

Expand All @@ -115,6 +115,52 @@ func Test_verifyRun_FailedNoAttestations(t *testing.T) {
baseRepo, err := ghrepo.FromFullName("owner/repo")
require.NoError(t, err)

var capturedParams api.FetchParams
attClient := &api.MockClient{
OnGetByDigest: func(params api.FetchParams) ([]*api.Attestation, error) {
capturedParams = params
return api.OnGetByDigestFailure(params)
},
}

cfg := &VerifyConfig{
Opts: &VerifyOptions{
TagName: tagName,
BaseRepo: baseRepo,
Exporter: nil,
},
IO: ios,
HttpClient: &http.Client{Transport: fakeHTTP},
AttClient: attClient,
AttVerifier: nil,
}

err = verifyRun(cfg)
require.ErrorContains(t, err, "no attestations for tag v1")
require.ErrorContains(t, err, "sha1:"+fakeSHA)
require.Equal(t, "sha1:"+fakeSHA, capturedParams.Digest)
}

func Test_verifyRun_FailedNoAttestations_SHA256(t *testing.T) {
ios, _, _, _ := iostreams.Test()
tagName := "v1"

fakeHTTP := &httpmock.Registry{}
defer fakeHTTP.Verify(t)
fakeSHA := "1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef"
shared.StubFetchRefSHA(t, fakeHTTP, "owner", "repo", tagName, fakeSHA)

baseRepo, err := ghrepo.FromFullName("owner/repo")
require.NoError(t, err)

var capturedParams api.FetchParams
attClient := &api.MockClient{
OnGetByDigest: func(params api.FetchParams) ([]*api.Attestation, error) {
capturedParams = params
return api.OnGetByDigestFailure(params)
},
}

cfg := &VerifyConfig{
Opts: &VerifyOptions{
TagName: tagName,
Expand All @@ -123,12 +169,14 @@ func Test_verifyRun_FailedNoAttestations(t *testing.T) {
},
IO: ios,
HttpClient: &http.Client{Transport: fakeHTTP},
AttClient: api.NewFailTestClient(),
AttClient: attClient,
AttVerifier: nil,
}

err = verifyRun(cfg)
require.ErrorContains(t, err, "no attestations for tag v1")
require.ErrorContains(t, err, "sha256:"+fakeSHA)
require.Equal(t, "sha256:"+fakeSHA, capturedParams.Digest)
}

func Test_verifyRun_FailedTagNotInAttestation(t *testing.T) {
Expand Down
Loading