fix: log ERI terway-compat tagging failures as warnings, not errors - #33
Merged
BSWANG merged 1 commit intoJul 14, 2026
Merged
Conversation
Tagging managed ERDMA ENIs for terway coexistence is best-effort: terway does not strictly depend on it, and the managed RAM role may lack ecs:TagResources (implicit-deny 403). Emitting these at error level printed a noisy stack trace on every reconcile. Downgrade the three tag-failure sites (backfill on existing ERIs, primary-ENI-after-RDMA-convert, and selected-ERIs) to info-level warnings. Behaviour is unchanged: each was already non-fatal and retried on the next reconcile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tagging managed ERDMA ENIs for terway coexistence (546dc87) is best-effort: terway does not strictly depend on it, and the ACK managed RAM role may lack ecs:TagResources (implicit-deny 403 each reconcile). Error-level logging printed a stack trace every reconcile though the failure is non-fatal (swallowed + retried). Downgrade the three tag-failure sites to info-level warnings. Verified on-cluster: single INFO warning line, no stack trace; eRDMA/SMC-R/device-plugin unaffected.