Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include user/password in share URL #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renaudguerin
Copy link
Contributor

Small QoL improvement to include the user / password of the share directly in the generated URL (except for SMB on Windows as I'm not sure the syntax is the same)

This allows for Cmd/Ctrl-clicking it from the terminal and be logged in instantly !

At first glance I don't believe there are adverse security consequences to that.

Tested with SMB on macOS only.

@AlexSSD7
Copy link
Owner

I actually tried putting this in earlier revisions of Linsk, but as it turned out later, Cmd/Ctrl+click onto a file share link appears to be working macOS only.

Another thing is that sometimes, the user might want to copy just the address without any credentials, and having to strip that manually would mean inconvenience that was not present before.

To address that, could you please make it a separate field. Something like a "Full URL"?

@renaudguerin
Copy link
Contributor Author

Does this look better ?
I haven't been able to actually test as I don't have my external ext4 drive with me.

@cbrunnkvist
Copy link

This is helpful. There's nothing that says we cannot display all of them: the share path, username, password, AND the full clickable URI. It's not like you're gonna run out of terminal space...

(btw there's even a bug in recent Finder versions, where the "Passwords..."-autocomplete hint interferes with Cmd-v pasting the password into the connect dialog)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants